Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp896064yba; Thu, 18 Apr 2019 11:22:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqyi86M4+YYPahf4f9l+GTJvOD4ho9+9GAgQ9kRyIVCrFTl+Dvv/GsCPXSZN6NINN5UbubDd X-Received: by 2002:a63:100e:: with SMTP id f14mr56108862pgl.192.1555611772917; Thu, 18 Apr 2019 11:22:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555611772; cv=none; d=google.com; s=arc-20160816; b=Ijh0dsr9Po6+RngFdxB2CuedsCN9wiMJ2rGNWdAQnAAC9FG1FNFrWjlIgs9cZj6Vvg jjqmj0LK+u2z+XpDmAHkc1dX8/50yrNRJRMGfiOjcbIWSjyo2rU02AbMSvGwvcLqFhyf 7V7XQ1AVJiBJXTvij+ot22h7klBhbW/XsIeadJphdphUfgAN+hX7GMFiu27BNHfCQH7H IbgoOWVLFWRIbXkdcBtRTIPKLm1dU4c5b4zrHKQlNjs5ijpNvs3cZ3ZfOb3VJ6AISvT+ K3YXrM2kz6cXHtlJHRz3rBHLBNvbkX3f+Ouu2jntuVCW+YHPYoWXWeeepWYI/SQz85iP qSQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=F1zuQ56RG7SiURqTfEHuaH9RCnwUEced5x5Pm1w0ly8=; b=0LXLT33YhFM2/R0bMJiZ+HsXk3CuuASbHpHo9jVsN3Sr2vdP7XNTBs2hXvzUKLR7Bt 5myp088VdAgud4li/zV9MO//QKjoo+uJxT7oWTzq2C5LHTSyD09pTnHmNPKDEZyHFz9V gBdQlLJJPW9jTTCNaN5ygde+9zPMNxLcEdobW4g3UZQdJZffTawxugfFlzup4zFaRpxb Ev9zfiQBFPEekuIkLAGUm6ZpzTJ9tq5QOuiED+Zu7uVk5J0U62yppOckQYjVjcVb/Koh j37DxNzPLih6RLBFzUbT1VAnTAgpvh+N4FwwoHpDEtxOlTzjEmLHbvRIMvA/RhDvuUx8 EVAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qOIN1eg0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v3si2584389plp.361.2019.04.18.11.22.38; Thu, 18 Apr 2019 11:22:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qOIN1eg0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391738AbfDRSIK (ORCPT + 99 others); Thu, 18 Apr 2019 14:08:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:39168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391727AbfDRSIH (ORCPT ); Thu, 18 Apr 2019 14:08:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 099EE21872; Thu, 18 Apr 2019 18:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555610886; bh=qdUeN1YLhpiBlZwvdf2IfQ0OpwD/83RG08fUEnWpIHo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qOIN1eg0GXNVrHvTMjiDOr/pO6E43/VlEqMWtcRJhaFDTCETzi4C6X+0u7VZ2IucD 2liPwMmOh9HU319/XEJRyNQTPGD+l9hKJYox5QLcfGXq1BWM+puRm1bPYNrwAdi3Nt pXhXvo6YFDjH+eTwqgwHIa3hoLIQ7dajD0FTyjYY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Takashi Iwai , Sasha Levin Subject: [PATCH 4.9 09/50] ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration Date: Thu, 18 Apr 2019 19:57:20 +0200 Message-Id: <20190418160423.951395888@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190418160422.455656724@linuxfoundation.org> References: <20190418160422.455656724@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit b4748e7ab731e436cf5db4786358ada5dd2db6dd ] The function snd_opl3_drum_switch declaration in the header file has the order of the two arguments on_off and vel swapped when compared to the definition arguments of vel and on_off. Fix this by swapping them around to match the definition. This error predates the git history, so no idea when this error was introduced. Signed-off-by: Colin Ian King Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/drivers/opl3/opl3_voice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/drivers/opl3/opl3_voice.h b/sound/drivers/opl3/opl3_voice.h index a371c075ac87..e26702559f61 100644 --- a/sound/drivers/opl3/opl3_voice.h +++ b/sound/drivers/opl3/opl3_voice.h @@ -41,7 +41,7 @@ void snd_opl3_timer_func(unsigned long data); /* Prototypes for opl3_drums.c */ void snd_opl3_load_drums(struct snd_opl3 *opl3); -void snd_opl3_drum_switch(struct snd_opl3 *opl3, int note, int on_off, int vel, struct snd_midi_channel *chan); +void snd_opl3_drum_switch(struct snd_opl3 *opl3, int note, int vel, int on_off, struct snd_midi_channel *chan); /* Prototypes for opl3_oss.c */ #ifdef CONFIG_SND_SEQUENCER_OSS -- 2.19.1