Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp897621yba; Thu, 18 Apr 2019 11:24:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqyWNlDB05rQIYsRNw3AnIn99wT16fHQSk8Tt9GNi9ytM6YcrVKqb9zt+6O3CVzhWbk/oE7D X-Received: by 2002:a63:cf:: with SMTP id 198mr37256740pga.228.1555611883065; Thu, 18 Apr 2019 11:24:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555611883; cv=none; d=google.com; s=arc-20160816; b=Jgh9KAJBg1U6R5qssF04RFzNRBJnpuXMGdO3Ji8LwHcit5IseOCGUk0KlEbha08Rm+ 66A+X2Bh0VScfT3hU5mjKenVqdGXnOjg4YjN8qg8TO8MTWjAN+OzJJOX9shXLrPRzIhb bjLpDgjIinNPByJKbrYaqbQeqgoPPTiQ1ptmIMK8pQBD0GnrTyfB94LUDuD59jlVvDgA J3EefS9QzcQMSRQ1gSJq4/QKd2DsjsH9W+kj6uZC8C/A+A8uaO4oWGfNq2cffGcuZyOT QRhEQKLVuJbkVt42suGCalLw0vAXaZCDtoGo1ag4Kvamn8sixNnlWNMd986n2kZG+kZw V1Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=l1+dzQAU09YyRkl26kWtrw2/v9/EqzHJKYek6oSRcR0=; b=VpHjB9TnSUt6ytqx9Iri0bSDczgmqub8M0dqcjj+E2HgOZoRvi09gCLNdO75ZoL51M 50horL9F18+NxAUK3y9Qj+/WFay8cgmrC7r9m1rpEPUZ6uXzJU+iWLOFq1mVWe5giH6+ or4xQikl+Im99CsUU/NWidzlnfFeiucYrn1aAO8YhbL/H47JaNytiTcICNR8ZLRp3hki Uj52TBFhrCxlCxLQfPAy78+m2n6iu29gVfEyJ8T4njaoiEqAa1Y5FSDRHaaHVRNhI/FT 1gOqIQxD9CD9YLb4DvrlYwLMum+H1/RGNOzvh1jU01siru7duW2qZqnTnfmPFav/yfMz kpQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LNdbeW3o; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r11si2460970pgp.337.2019.04.18.11.24.27; Thu, 18 Apr 2019 11:24:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LNdbeW3o; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403995AbfDRSVg (ORCPT + 99 others); Thu, 18 Apr 2019 14:21:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:41330 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391610AbfDRSJk (ORCPT ); Thu, 18 Apr 2019 14:09:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 806B82186A; Thu, 18 Apr 2019 18:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555610980; bh=Wp9HFVpCPvkH0jPAss366Yc/j16eP2Ww9+UJdbU3oOQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LNdbeW3oKK2QhOkzFrcXQudx7gFDY5l2xVZAHP1NnCPcxdZi/tJ9N/RWNm14eb8up v6CCNcc41FnfPDuseWwuwdwW452hhpvcJUdDTHEOgQC/Dg2U/8Kw/5ciHds7Rr7J/s w6h9qtffLhIlCqtn9YU2ikPpPZk3R9aE0SPuaoVY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Vetter , Sean Paul , Dave Airlie , Sasha Levin Subject: [PATCH 5.0 13/93] drm/udl: use drm_gem_object_put_unlocked. Date: Thu, 18 Apr 2019 19:56:51 +0200 Message-Id: <20190418160438.213533035@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190418160436.781762249@linuxfoundation.org> References: <20190418160436.781762249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 8f3b487685b2acf71b42bb30d68fd9271bec8695 ] When Daniel removed struct_mutex he didn't fix this call to the unlocked variant which is required since we no longer use struct mutex. This fixes a bunch of: WARNING: CPU: 4 PID: 1370 at drivers/gpu/drm/drm_gem.c:931 drm_gem_object_put+0x2b/0x30 [drm] Modules linked in: udl xt_CHECKSUM ipt_MASQUERADE tun bridge stp llc nf_conntrack_netbios_ns nf_conntrack_broadcast xt_CT ip6t> CPU: 4 PID: 1370 Comm: Xorg Not tainted 5.0.0+ #2 backtraces when you plug in a udl device. Fixes: ae358dacd217 (drm/udl: Get rid of dev->struct_mutex usage) Reviewed-by: Daniel Vetter Cc: Sean Paul Signed-off-by: Dave Airlie Signed-off-by: Sasha Levin --- drivers/gpu/drm/udl/udl_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c index d5a23295dd80..bb7b58407039 100644 --- a/drivers/gpu/drm/udl/udl_gem.c +++ b/drivers/gpu/drm/udl/udl_gem.c @@ -224,7 +224,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device *dev, *offset = drm_vma_node_offset_addr(&gobj->base.vma_node); out: - drm_gem_object_put(&gobj->base); + drm_gem_object_put_unlocked(&gobj->base); unlock: mutex_unlock(&udl->gem_lock); return ret; -- 2.19.1