Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] stmmac: pci: Adjust IOT2000 matching
To:     David Miller <davem@davemloft.net>
Cc:     peppe.cavallaro@st.com, alexandre.torgue@st.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        baocheng.su@siemens.com, andy.shevchenko@gmail.com
References: <5a547510-2605-bae5-bd58-ab4aff28840d@siemens.com>
 <20190418.104344.957038152341042514.davem@davemloft.net>
From:   Jan Kiszka <jan.kiszka@siemens.com>
Message-ID: <642a6059-8a28-b995-919f-68d03200ee11@siemens.com>
Date:   Thu, 18 Apr 2019 20:24:28 +0200
User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12)
 Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666
MIME-Version: 1.0
In-Reply-To: <20190418.104344.957038152341042514.davem@davemloft.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 18.04.19 19:43, David Miller wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> Date: Thu, 18 Apr 2019 11:14:56 +0200
> 
>> @@ -170,8 +176,6 @@ static const struct dmi_system_id quark_pci_dmi[] = {
>>   	{
>>   		.matches = {
>>   			DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
>> -			DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
>> -					"6ES7647-0AA00-1YA2"),
>>   		},
>>   		.driver_data = (void *)&iot2040_stmmac_dmi_data,
> 
> So really, every IOT2000 that doesn't have the IOT2020 asset tag will be
> a 2040?  Forever?
> 

Yes, seriously. The next version won't have all that DMI and ACPI stuff. And if 
there will ever be a version with that again, it will not be labeled "IOT2000" 
via the board name entry. And it will have more robust hardware discovery as 
well. Lesson(s) learned, in fact not only for this product series.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux