Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 18 Apr 2019 11:48:16 -0700 (PDT)
Message-Id: <20190418.114816.565540261058466105.davem@davemloft.net>
To:     jan.kiszka@siemens.com
Cc:     peppe.cavallaro@st.com, alexandre.torgue@st.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        baocheng.su@siemens.com, andy.shevchenko@gmail.com
Subject: Re: [PATCH] stmmac: pci: Adjust IOT2000 matching
From:   David Miller <davem@davemloft.net>
In-Reply-To: <642a6059-8a28-b995-919f-68d03200ee11@siemens.com>
References: <5a547510-2605-bae5-bd58-ab4aff28840d@siemens.com>
        <20190418.104344.957038152341042514.davem@davemloft.net>
        <642a6059-8a28-b995-919f-68d03200ee11@siemens.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Jan Kiszka <jan.kiszka@siemens.com>
Date: Thu, 18 Apr 2019 20:24:28 +0200

> On 18.04.19 19:43, David Miller wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>> Date: Thu, 18 Apr 2019 11:14:56 +0200
>> 
>>> @@ -170,8 +176,6 @@ static const struct dmi_system_id quark_pci_dmi[]
>>> = {
>>>   	{
>>>   		.matches = {
>>>   			DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
>>> -			DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
>>> -					"6ES7647-0AA00-1YA2"),
>>>   		},
>>>   		.driver_data = (void *)&iot2040_stmmac_dmi_data,
>> So really, every IOT2000 that doesn't have the IOT2020 asset tag will
>> be
>> a 2040?  Forever?
>> 
> 
> Yes, seriously. The next version won't have all that DMI and ACPI
> stuff. And if there will ever be a version with that again, it will
> not be labeled "IOT2000" via the board name entry. And it will have
> more robust hardware discovery as well. Lesson(s) learned, in fact not
> only for this product series.

Ok, applied, thanks.