Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp926646yba; Thu, 18 Apr 2019 11:57:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqxi98VsmrrNr1q1+tsrc51bbsF7cX23YjNLTSiyT9MQCt0zRuMqYPIGPIu2PJxmCpsEObjb X-Received: by 2002:a63:db10:: with SMTP id e16mr89578748pgg.142.1555613873850; Thu, 18 Apr 2019 11:57:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555613873; cv=none; d=google.com; s=arc-20160816; b=tRKXaxQvaX162WePn0jHFx4qcQB3s2A2g+JHOvaXDwPXTk7ctyN81htK01j5rSPbKY QwfKqWKt0ofgSZnDJ5/HUnwcPcxTOy1Unec18RCf2OMoT+4jT88z6FPghsUEWknLPp5V pYwq/OOuGZW9p5ov+CdrOweW1DtDcJdUP2PYv6hUhEXev/zNR6IRX+MG6VblfMYZ/jmz cOmPlMrT4V/2mbFhiWWS7EPAhUQVnUbpy40zLvmGeuDjvC+u0f5tRi5gLtynQXPm0GqK xTP2GEiY1b/Obgp6r+jBvftTlPrH7comH3asLyg6Cj6XUra9Use1p5hOIYZ3/fBEZjd9 isGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=bMptNhnZCZTXI0pt5KN6K+BnHu1TIWjNxp9a4N1b+Ek=; b=EDwwQIRrrv/bg1yGDgxqQsEHBB5dKY4zAQ0A5MbZZwbbe2nXzE0StM5IDiByyJC7Ye yi2dDAJq/8L8Va5MHtSfrr0y54m/8PH574uY9JyxSwQmHOGgz8lXmpOl3SLSF3Fpixnn ACcn/XERfnFCaRtnhTqwUDiirYT/lQTMacMtxVkwCrvLnCL4w68M/3yUmWqrxfFR6DVN qQrwPvhTI3PrSt53ua29T1ciWA+SeXC4WyXFrYMQrNWo0SQ/kEA+cifgeLTC0lUvjHPO 6S3pat8iJpuZ0PlJ5bzyjma0X7MC4sR2zB1uD0go6fGPOS70l9LzUUOeBPEsMsRX5nsC I/Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y11si2714607plr.384.2019.04.18.11.57.38; Thu, 18 Apr 2019 11:57:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389888AbfDRS4l (ORCPT + 99 others); Thu, 18 Apr 2019 14:56:41 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44386 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbfDRS4l (ORCPT ); Thu, 18 Apr 2019 14:56:41 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 44BD614877C17; Thu, 18 Apr 2019 11:56:40 -0700 (PDT) Date: Thu, 18 Apr 2019 11:56:39 -0700 (PDT) Message-Id: <20190418.115639.4353812313618266.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: aryabinin@virtuozzo.com, edumazet@google.com, mgorman@techsingularity.net, willemb@google.com, fw@strlen.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/4] net/skbuff: don't waste memory reserves From: David Miller In-Reply-To: <791f4f23-d931-4ac8-4e60-3ffe46c4ece2@gmail.com> References: <20190418180524.23489-1-aryabinin@virtuozzo.com> <791f4f23-d931-4ac8-4e60-3ffe46c4ece2@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Apr 2019 11:56:40 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet Date: Thu, 18 Apr 2019 11:55:16 -0700 > AFAIK, drivers allocate skbs way before a frame is actually received, > (at RX ring buffer initialization or refill) > > So sk_memalloc_socks() might be false at that time, but true later. This is exactly what I was going to say too.