Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Janusz Krzysztofik <jmkrzyszt@gmail.com>
To:     Miquel Raynal <miquel.raynal@bootlin.com>
Cc:     Aaro Koskinen <aaro.koskinen@iki.fi>,
        Tony Lindgren <tony@atomide.com>,
        Boris Brezillon <bbrezillon@kernel.org>,
        Richard Weinberger <richard@nod.at>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: ams-delta: Drop board specific partition info
Date:   Thu, 18 Apr 2019 21:11:14 +0200
Message-ID: <5022351.qh9aoUC7DE@z50>
In-Reply-To: <20190418084929.7ac2cb67@xps13>
References: <20190319223718.26131-1-jmkrzyszt@gmail.com> <3638685.4RdFRBT8kZ@z50> <20190418084929.7ac2cb67@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Miqu=E8l,

I'm wondering if we could register up a custom mtd partition parser from th=
e=20
board file.  It could return a pointer to a statically defined table.  Then=
 we=20
could add its name to the list of parsers the driver is going to try if the=
=20
board is enabled in .config.
Would that be acceptable from the MTD subsystem point of view?

Thanks,
Janusz


On Thursday, April 18, 2019 8:49:29 AM CEST Miquel Raynal wrote:
> Hi Janusz,
>=20
> Janusz Krzysztofik <jmkrzyszt@gmail.com> wrote on Thu, 18 Apr 2019
> 01:09:59 +0200:
>=20
> > Hi Aaro, Tony,
> >=20
> > On Wednesday, April 17, 2019 11:40:10 AM CEST Miquel Raynal wrote:
> > > Hi Janusz,
> > >=20
> > > Janusz Krzysztofik <jmkrzyszt@gmail.com> wrote on Sun, 24 Mar 2019
> > > 23:33:44 +0100:
> > >  =20
> > > > After recent modifications, only a hardcoded partition info makes
> > > > the driver device specific.  Other than that, the driver uses GPIO
> > > > exclusively and can be used on any hardware.
> > > >=20
> > > > Drop the partition info and use MTD partition parser with default l=
ist
> > > > of parser names instead.  For the OF parser to work correctly, pass
> > > > device of_node to mtd.
> > > >=20
> > > > Amstrad Delta users should append the following partition info to=20
their
> > > > kernel command line, possibly by embedding it in CONFIG_CMDLINE:
> > > >=20
> > > > mtdparts=3Dams-delta-nand:3584k(Kernel),256k(u-boot),256k(u-
boot_params),\
> > > > 256k(Amstrad_LDR),27m(File_system),768k(PBL_reserved).
> > > >=20
> > > > For their convenience, CONFIG_MTD_CMDLINE_PARTS symbol is selected
> > > > automatically from that board Kconfig if this NAND driver is also
> > > > selected.
> > > >=20
> > > > Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > --- =20
> > >=20
> > > FYI I am okay with the change but I am waiting for acks before applyi=
ng
> > > it. =20
> >=20
> > May we have an ack from you?
> >=20
> > If still not convinced with my clarifications, I can add a comment to h=
elp=20
text=20
> > in Kconfig, either squashed or in a follow up patch, on the requirement=
 of=20
> > appending mtdparts parameter to command line.  What do you think?
>=20
> In the same patch I guess that would be fine.
>=20
> Thanks,
> Miqu=E8l
>=20