Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp985658yba; Thu, 18 Apr 2019 13:03:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqwA1NZt00ueNHwrFudcM8//31i1rOLxHSfVjjSepK1lpWiLIbAYuo64TzGc2W9xAkvPBVLs X-Received: by 2002:a17:902:822:: with SMTP id 31mr71717371plk.41.1555617807453; Thu, 18 Apr 2019 13:03:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555617807; cv=none; d=google.com; s=arc-20160816; b=OhVH8VGGM6f1TISaER/9kh+A6b8MEdFcEoke3rf8ifnbmG3F7fH9HRGqyaXppFvkeW hT5eIPwbaAz3YudocL2AmOwINt9R2k1lBf6Eg0NmSPi5wBhNWRWaLf+SpzG0hTIYgn6N HqezS3V5w5ZUNZ5HPxMYBhESQ+4mxvHGm7lTWu12jJsyubhdMTHdZSrv0oLi68fLy2Vb V8qgxObHWGyu5BI3BlEvsfN0Z1JL+lO0Z9rN1Nik0Uf2Iqiws9Z7HEb6apXp6QEb7B1C 4n0rMVVklTJCcT2tB1ULiCiPQirpKaIVgeBf2ImiAxMFFQm7XNPXxwDAlTX7LzKIFq3F D5lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Nv1osdKMnyQhFpXAYzfTc/y8P4eQhfnwJ3z9VJHumRs=; b=PVuRcHjSq2xuqAoKvZO/GoRKL2bz0lOKPcSQaQlM+GcI2D3uyflc7kIdCWYn50nV75 nkZvsHnTcZlF4Fn73a5KiUkfQpd+MJBJ+yxmFMO2gOm5yzRTbmhQKyYWCsHxc7qdf112 td83cNshoRXwQVCg/i183qOsCNnKHlsaeVi77gofA5qHrIJH5UU/99O55MoxggOova6L 9ezh720cwQt/dJSJiTAyxQ0hst7YiwJLH/l4xxjr52X7HwrgYJMcKpg6RC8CTsBJqPWO Otjju+p7vQ17Qqucn2OCrBNTjc1NTU8vOBnMPJbzJ4QAYd/AtWCX2QOa/xte2h3TehQc 016w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XnGy8nV+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y71si2680828pgd.51.2019.04.18.13.03.12; Thu, 18 Apr 2019 13:03:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XnGy8nV+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390045AbfDRTtC (ORCPT + 99 others); Thu, 18 Apr 2019 15:49:02 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:46086 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389866AbfDRTtC (ORCPT ); Thu, 18 Apr 2019 15:49:02 -0400 Received: by mail-pf1-f194.google.com with SMTP id 9so1552149pfj.13 for ; Thu, 18 Apr 2019 12:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Nv1osdKMnyQhFpXAYzfTc/y8P4eQhfnwJ3z9VJHumRs=; b=XnGy8nV+vrlbZLrGOz/2ITivLC4FD5nuOPNiQP39Nwi2Gff+bcupMcExivueyD+z4q Go4gLOQzKLBdAhlU1UFvA6mJ/k2mQAsY0MiA6Fj/0c2Uks1VRkL5eMVDgdeSFuqqHknh gFqVhfzZEtWCIJZzGTm9argq1WxEObOFJLsFmk181hFJUQ/4Rwa9wmOHbhQWBXSzvrLX ZDf/iLZrVTMrUuPGKKCkPG3jc3FJVXRUsRCwB7fIUkgz9zul3803EgfjxsaVzR27tsqi yia0T6ibseVHWa1l1bBeAXTCpcCG1vnuUKn6pY00thLmzsPgbupuGk6nwMDrLlgyL8nS PbWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Nv1osdKMnyQhFpXAYzfTc/y8P4eQhfnwJ3z9VJHumRs=; b=Wvxis3A3XZxNpWBYmReG5HIGLiRO3E3L/qPmxzn3t2PSZhfofwzx4ASP5RrATotiTL d3M2qrSQo+ElqeAcpUCiP0d+BbdUQMvkx5Zzg4LyU4VQYCz7oPt1CGRjQrRpghbyyBaW Dt2Qb8bt8OQOjERuOa8f+SSHYrkNFKe0mAHaLRS+B6bZII12siPrLfDFiDlZHCjasX/8 L8YwIC4IauqGG0mr9y/ZWhTP59GwEwbgv4YkqTEfcVP8Oil09YUWbmyUadnIsyAzUnfR 9O1WJwHAeeXXi3UiDkErTcury7PXARZZdYZKI049xbzWqEpoaesvi1Cb66KpsqaW21e2 OZZA== X-Gm-Message-State: APjAAAX+qHbdyH0G4myoApLFWIHNX5YzRj4avLDVTQcnGFeFSDhLeYbG UbApCaqi/NSTyPX1XME4504= X-Received: by 2002:a65:4bce:: with SMTP id p14mr92784659pgr.376.1555616941584; Thu, 18 Apr 2019 12:49:01 -0700 (PDT) Received: from Asurada-Nvidia.nvidia.com (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id m23sm3924311pfa.117.2019.04.18.12.49.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2019 12:49:01 -0700 (PDT) Date: Thu, 18 Apr 2019 12:48:58 -0700 From: Nicolin Chen To: "S.j. Wang" Cc: "timur@kernel.org" , "Xiubo.Lee@gmail.com" , "festevam@gmail.com" , "broonie@kernel.org" , "alsa-devel@alsa-project.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2] ASoC: fsl_esai: Add pm runtime function Message-ID: <20190418194857.GB14885@Asurada-Nvidia.nvidia.com> References: <8c78be27ef3795e9b870de7789c25454bd3774b3.1555586023.git.shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c78be27ef3795e9b870de7789c25454bd3774b3.1555586023.git.shengjiu.wang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 18, 2019 at 11:34:15AM +0000, S.j. Wang wrote: > Add pm runtime support and move clock handling there. > fsl_esai_suspend is replaced by pm_runtime_force_suspend. > fsl_esai_resume is replaced by pm_runtime_force_resume. The change looks fine, yet I'd prefer to have a good justification in the commit message. It could be simply some benefit of doing so like what you have discussed with Mark. > Signed-off-by: Shengjiu Wang Please add it in next version upon commit message update: Acked-by: Nicolin Chen Thanks