Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1012579yba;
        Thu, 18 Apr 2019 13:35:24 -0700 (PDT)
X-Google-Smtp-Source: APXvYqxs/PZB/xJP+hL8G47Ow4h+lk4MNo/LI1WgbWdFfy/gnRC6xO+uRvprT255QjFuMAnRkElk
X-Received: by 2002:a17:902:b7c7:: with SMTP id v7mr4697546plz.122.1555619724290;
        Thu, 18 Apr 2019 13:35:24 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1555619724; cv=none;
        d=google.com; s=arc-20160816;
        b=BwIEo3hV5vhfqEiXfPm4ZkMdn+J3KNlt3Ivq0/8TXHunS1wLhO9+0yfydKPZ252h9b
         0JqpUXpLSuOdPLXoXoYpCYXXp/paHu7SFo8+fNz0QHQlVvnRJkleWXH6Sr07Ec7u2M2y
         EY7MJMGGngc4VJp3WWf4QndhypU8jH0ZrWcxMOqwy5z6Dg6P8+dNPyAqh3GBSaSC9OlD
         3X8obcBry0yR5mmmPAl2XjihhinqlDdQXBo9lRKXkjKjqrE+1S8h/ia3kb0d6JfLKwbZ
         N0So4YLcXVi0vXllf9ugiuddueH1dMFb5hwliLG3T+lDz/nBF8hQP6k9BveR3T89BB7S
         DjaQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:mime-version:references
         :in-reply-to:message-id:date:subject:cc:to:from;
        bh=T3JD0sgSOXk1vRSr1uVe9SorhMd4n+SS+HWTi6IFNCc=;
        b=zgRcbGIwbqfoRAMmOQrywEfF/irRdOZOhd4pFMry77+tiTHBcTFFU26DNdFg3bVQ5u
         N5eBv26vRoO7mO7OABVlbeUhciMuZjojEAlMh75XrSjbkLuKnRkzJQ4KtaI3DjWisJzH
         mdX3H3P/ZKqiufyhSXyIYDnRuKRBbVBLOFJOmkPkLj2FWDWtNntbjuTn7frseEK2LAEh
         w8CVlcyZF6f5GbB0wnVxQ4uYaNi6PhdQEQ0TAkxKZgrhKk6UKI/T1g42u60BW7p3EaJ3
         GW0zKrK1/voLi103mdco1RJWEMci+Ct1XuR1v+LCfP4lar0Gv1kxPIfpxvhnJjPIXRTP
         bU4Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=SwnFKNon;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id v21si3217041pfe.119.2019.04.18.13.35.09;
        Thu, 18 Apr 2019 13:35:24 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=SwnFKNon;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2390036AbfDRUac (ORCPT <rfc822;lxz1983@gmail.com> + 99 others);
        Thu, 18 Apr 2019 16:30:32 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:17090 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1731565AbfDRUab (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 18 Apr 2019 16:30:31 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5cb8de6c0001>; Thu, 18 Apr 2019 13:30:36 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 18 Apr 2019 13:30:31 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 18 Apr 2019 13:30:31 -0700
Received: from [10.2.163.72] (172.20.13.39) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 18 Apr
 2019 20:30:29 +0000
From:   Zi Yan <ziy@nvidia.com>
To:     Yang Shi <yang.shi@linux.alibaba.com>
CC:     <mhocko@suse.com>, <kirill.shutemov@linux.intel.com>,
        <rppt@linux.vnet.ibm.com>, <corbet@lwn.net>,
        <akpm@linux-foundation.org>, <linux-doc@vger.kernel.org>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] doc: mm: migration doesn't use FOLL_SPLIT anymore
Date:   Thu, 18 Apr 2019 16:30:27 -0400
X-Mailer: MailMate (1.12.4r5622)
Message-ID: <C8CBF3A3-5ADA-4CA6-8AEB-4836AE9146D7@nvidia.com>
In-Reply-To: <1555618624-23957-1-git-send-email-yang.shi@linux.alibaba.com>
References: <1555618624-23957-1-git-send-email-yang.shi@linux.alibaba.com>
MIME-Version: 1.0
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL103.nvidia.com (172.20.187.11) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; format=flowed
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1555619436; bh=T3JD0sgSOXk1vRSr1uVe9SorhMd4n+SS+HWTi6IFNCc=;
        h=X-PGP-Universal:From:To:CC:Subject:Date:X-Mailer:Message-ID:
         In-Reply-To:References:MIME-Version:X-Originating-IP:
         X-ClientProxiedBy:Content-Type;
        b=SwnFKNonXOE1zQVJWCyAkBVjCLR/gdo0c98WcA4gmTZefaRGQCthtZhxg/jleQzpb
         9ey3mfNA2l5uwtSrjts4734cmnAQzrvuHJkA0/uVgRhdrUSqaEEH5iSCLqsgZ+z1mf
         eeg11NLcYkIb/mqsgxPlqRYvLKPIDYGdSbrtnlZUeJ4SkRHOQlXkM81nzq/VmKWoBq
         F+ZustVToSp/Ww2x7qBHKYszHEDGptzDItgUiSNegC2a4t8wVt2Udzszw5zk7EYoRl
         T2VVXWCXJVBoGCwEAjqmLJrf4butHZI6agSmOQ0mGBaG9CzXgI07vrYyRDygRIjFSL
         N81lBCiahYjRw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 18 Apr 2019, at 16:17, Yang Shi wrote:

> When demonstrating FOLL_SPLIT in transhuge document, migration is used
> as an example.  But, since commit 94723aafb9e7 ("mm: unclutter THP
> migration"), the way of THP migration is totally changed.  FOLL_SPLIT 
> is
> not used by migration anymore due to the change.
>
> Remove the obsolete example to avoid confusion.
>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
> ---
>  Documentation/vm/transhuge.rst | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/Documentation/vm/transhuge.rst 
> b/Documentation/vm/transhuge.rst
> index a8cf680..8df3806 100644
> --- a/Documentation/vm/transhuge.rst
> +++ b/Documentation/vm/transhuge.rst
> @@ -55,13 +55,7 @@ prevent page from being split by anyone.
>  In case you can't handle compound pages if they're returned by
>  follow_page, the FOLL_SPLIT bit can be specified as parameter to
>  follow_page, so that it will split the hugepages before returning
> -them. Migration for example passes FOLL_SPLIT as parameter to
> -follow_page because it's not hugepage aware and in fact it can't work
> -at all on hugetlbfs (but it instead works fine on transparent
> -hugepages thanks to FOLL_SPLIT). migration simply can't deal with
> -hugepages being returned (as it's not only checking the pfn of the
> -page and pinning it during the copy but it pretends to migrate the
> -memory in regular page sizes and with regular pte/pmd mappings).
> +them.
>
>  Graceful fallback
>  =================
> -- 
> 1.8.3.1

Thanks for updating the document.

Reviewed-by: Zi Yan <ziy@nvidia.com>



--
Best Regards,
Yan Zi