Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190408173252.37932-3-eranian@google.com> <tip-f447e4eb3ad1e60d173ca997fcb2ef2a66f12574@git.kernel.org>
 <alpine.DEB.2.21.1904161227001.20764@macbook-air> <20190417060625.GB97541@gmail.com>
In-Reply-To: <20190417060625.GB97541@gmail.com>
From:   Stephane Eranian <eranian@google.com>
Date:   Thu, 18 Apr 2019 14:50:14 -0700
Message-ID: <CABPqkBQ=pLuu_Qv5u_7hM+LH8=Ys+ZhTPkcQyVY4zJasVBiqYg@mail.gmail.com>
Subject: Re: [tip:perf/core] perf/x86/intel: Force resched when TFA sysctl is modified
To:     Ingo Molnar <mingo@kernel.org>
Cc:     Vince Weaver <vincent.weaver@maine.edu>,
        Peter Zijlstra <peterz@infradead.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, linux-tip-commits@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Vince

On Tue, Apr 16, 2019 at 11:06 PM Ingo Molnar <mingo@kernel.org> wrote:
>
>
> * Vince Weaver <vincent.weaver@maine.edu> wrote:
>
> > On Tue, 16 Apr 2019, tip-bot for Stephane Eranian wrote:
> >
> > > Commit-ID:  f447e4eb3ad1e60d173ca997fcb2ef2a66f12574
> > > Gitweb:     https://git.kernel.org/tip/f447e4eb3ad1e60d173ca997fcb2ef2a66f12574
> > > Author:     Stephane Eranian <eranian@google.com>
> > > AuthorDate: Mon, 8 Apr 2019 10:32:52 -0700
> > > Committer:  Ingo Molnar <mingo@kernel.org>
> > > CommitDate: Tue, 16 Apr 2019 12:19:35 +0200
> > >
> > > perf/x86/intel: Force resched when TFA sysctl is modified
> >
> > What's TFA?  Tuna-fish-alarm?
>
> Heh, I wish! :-)
>
Sorry about the confusion. I was just trying to mimic the function
names that Peter used
in the code. Hard to fit the whole sysctl name in the title, anyway.

> > [...] Nowhere in the commit or in the code does it ever say what a TFA
> > is or why we'd want to resched when it is modified.
>
> Yeah, it's the TSX-Force-Abort acronym - Intel has numbed our general
> dislike to random acrynyms ...
>
> Peter and me usually fix such changelog context omissions, but this one
> slipped through. :-/
>
> The commit is too deep down perf/core already to rebase it just for the
> changelog, but if we are going to rebase it for some functional reason
> I'll take care of it next time around.
>
> TFA. (Thanks For your Assistance. :-)
>
>         Ingo