Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1189366yba; Thu, 18 Apr 2019 17:11:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqzpyuvaAA071/hstNfPldwtAESm+CiIgkg/e2Espn1sbp/wQnirVIWn/JWz3ZDY1Io3nURW X-Received: by 2002:aa7:8392:: with SMTP id u18mr572597pfm.217.1555632686293; Thu, 18 Apr 2019 17:11:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555632686; cv=none; d=google.com; s=arc-20160816; b=mmfAn045cdVd4+ptWx8oLOIUP0P3skqjDosz3IRChbJHMWGaYZLfFkBjI7JtCgOYK3 iNrplL5bK1aHHr031K29tQcPeakRVhoIzUFFoGWV3/DIYQ/gOp4xHWtClrlxMGjZqdpi 3mTLEYJPej+y1r6AywPlSqDrPjSQ3GzK2KynAgibwEQ6e/CoOgPjV8YOcfeonrEb3iuE t/hq5lxkI3eVQRhbG5sVob77Le04MNDroh9+B3JdxvDAAIWXtQwpW79qEN0ZmTYp/Dpf dQQ6UKgyxVRKPkpdCHtOWFwzP6aEH2MEwOWB9xN24SNKWfhsh5POOa0ak7NqO+wdPzcH rI2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=s88pUaiJXZpTSw8Fv1vmmiqH6w+bvykwROczCT1StuQ=; b=gFaVZjWwSJX4lWb/NjB7XOL4w3i9/getWVbkSJshFnUs1r8Ld/ca570oPmbPq+TJzp V8bJ1uHyqQU6yWMKgQafWJdIg7HdUWQzziQF0UQT561cnkyk49wptM+0YnysMdgUqew4 YMyL5WSQFhDzCXeYYLbK3U5QwUAuJDQSBrmlVAgLhg8Vrgnb7ilh4i9XNReBrwZfQzW3 kRjwT8ow5l0VEPhuWuH6SuwXkPbDquoXXvgE1Qmck47DwiD+4n0m3VqqNUytfmkWs7Wm 4dGPDIa24VF+lcUoVPgX1N+j2277IVXo3PCiw6KhwCFiiIYcU60pt5g8n1Hoc3ZoM9fs RABw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g189si3898595pfb.289.2019.04.18.17.11.11; Thu, 18 Apr 2019 17:11:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726474AbfDSAKU (ORCPT + 99 others); Thu, 18 Apr 2019 20:10:20 -0400 Received: from anholt.net ([50.246.234.109]:41332 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725917AbfDSAKT (ORCPT ); Thu, 18 Apr 2019 20:10:19 -0400 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 5C92D10A3377; Thu, 18 Apr 2019 17:10:19 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8vcSX3UXRkpk; Thu, 18 Apr 2019 17:10:18 -0700 (PDT) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id EB21010A339C; Thu, 18 Apr 2019 17:10:15 -0700 (PDT) Received: by eliezer.anholt.net (Postfix, from userid 1000) id DD41D2FE3AA4; Thu, 18 Apr 2019 17:10:14 -0700 (PDT) From: Eric Anholt To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Paul Kocialkowski , Maxime Ripard , david.emett@broadcom.com, thomas.spurden@broadcom.com, Eric Anholt Subject: [PATCH 1/4] drm/v3d: Fix debugfs reads of MMU regs. Date: Thu, 18 Apr 2019 17:10:11 -0700 Message-Id: <20190419001014.23579-1-eric@anholt.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org They're in the hub, not the individual cores. Signed-off-by: Eric Anholt --- drivers/gpu/drm/v3d/v3d_debugfs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d_debugfs.c b/drivers/gpu/drm/v3d/v3d_debugfs.c index a2dc4262955e..356a8acfa72d 100644 --- a/drivers/gpu/drm/v3d/v3d_debugfs.c +++ b/drivers/gpu/drm/v3d/v3d_debugfs.c @@ -26,6 +26,10 @@ static const struct v3d_reg_def v3d_hub_reg_defs[] = { REGDEF(V3D_HUB_IDENT3), REGDEF(V3D_HUB_INT_STS), REGDEF(V3D_HUB_INT_MSK_STS), + + REGDEF(V3D_MMU_CTL), + REGDEF(V3D_MMU_VIO_ADDR), + REGDEF(V3D_MMU_VIO_ID), }; static const struct v3d_reg_def v3d_gca_reg_defs[] = { @@ -50,9 +54,6 @@ static const struct v3d_reg_def v3d_core_reg_defs[] = { REGDEF(V3D_PTB_BPCA), REGDEF(V3D_PTB_BPCS), - REGDEF(V3D_MMU_CTL), - REGDEF(V3D_MMU_VIO_ADDR), - REGDEF(V3D_GMP_STATUS), REGDEF(V3D_GMP_CFG), REGDEF(V3D_GMP_VIO_ADDR), -- 2.20.1