Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1208594yba; Thu, 18 Apr 2019 17:35:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqzSgHkKmpUmbmRj8t5xlOYii1eSElPfI0633qujMXNDMZd19rooPsXR3tSZRkaBRxn1MXZR X-Received: by 2002:a17:902:b407:: with SMTP id x7mr682631plr.288.1555634157800; Thu, 18 Apr 2019 17:35:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555634157; cv=none; d=google.com; s=arc-20160816; b=b4/WuG9yseNfZYJIXAOmTDdS34Mq4etc7Zetr7ltLAuoM+wtjTYDg8eKy7TNQyWRSj Ron0pj5LNNM5W2X7nzqJvWOam8NhT6w6ofBHuITet6tar0/2Vb1dXJ2vsjKMPHL72bUq SHbnRRxp3YfDmMaUFArPEDeI/EDaFPiLoLx9c6laOEBR0382rGyal1fqne08WR0SWNb8 HNr9r+jAoHKcfTwS5TltWI4HzyPsfr5wkt4z64Sf2xlOAijK5bskiRot2qN0G8+J0Xaw MWURHV63iS2JVP7V4V3VUnOlwOKCOzlY65+4xFdQ0mBD74IQW/wDgD5//6eQW8ux2kEC kvQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=6hr9wOAg/2Gq9iOyAv8Cy8Ccua3tVlGNSGr4rrWv3K4=; b=kJuX/kGkpl0Zx4m7JmXY4f0C+GT1kpiJhcATEXGBH8B0ThzeB4i1P1tydTptJlCMhq DqGPDDMVJ/iSmn7tbehCuReRYn693ZEHIRPkOYDKVL8AF32VIKFNmQGkYwLXiRTIkzLP BMo0YSp2j8ijZLm8WDaB/p24UQ8H9xifJv5k/QTSwnMG2cFvfdTnRiPRe3f1i03SQsjv /7Qi81iYSKWEuB2hZ5EJXOi0yCsDpVoPPnfLL64cX/VdDM2JJQUH4wvJ/hKQCQNnDeAs 7AEPHauj3xEuma+dNsdNHb3G0DWKR/qmsentLyHqhGrAI1+cSZHhcpAHJjD3OKqHuicr BY6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=j77Im32A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j9si3559246plk.125.2019.04.18.17.35.41; Thu, 18 Apr 2019 17:35:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=j77Im32A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726522AbfDSAdc (ORCPT + 99 others); Thu, 18 Apr 2019 20:33:32 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:45224 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbfDSAdc (ORCPT ); Thu, 18 Apr 2019 20:33:32 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3J0SsUk187711; Fri, 19 Apr 2019 00:33:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=6hr9wOAg/2Gq9iOyAv8Cy8Ccua3tVlGNSGr4rrWv3K4=; b=j77Im32AKoSQaa25bDt7szeMKo5maZmF3i0q7fCfXCMsavw0Atwy02G52uleAINhnAib zusKOzXL6j2PmQlV3uRt0+rAULzUlpoeRLw1mb/qoLIANNYxcXmCXECOqiy40o7g3pVs qtBaglOX7UZ92hLHIFfjk4G+c4dJbkrzKBUK8fuGFrsOYfLHKLu09JgDvq26OXJRwNYM ieIzsf/7Y3oAX49KjcK7aojib/BznrksEBssRVWOYQ93mwe76VJqAhRsTv1sh7rzX8PD mgnksLf/yNXP+G10j7bWhUp9CuNhn8I/TUAOKKJB2vBfEK2qQRZvpxYlv81tMFCd//VQ ow== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2rusnf9hs4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Apr 2019 00:33:25 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3J0WUrM077256; Fri, 19 Apr 2019 00:33:25 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2rubq7tp3t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Apr 2019 00:33:25 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x3J0XO1V009181; Fri, 19 Apr 2019 00:33:24 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 18 Apr 2019 17:33:23 -0700 To: Colin King Cc: QLogic-Storage-Upstream@cavium.com, "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] scsi: qedf: remove memset/memcpy to nfunc and use func instead From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190412094829.15868-1-colin.king@canonical.com> Date: Thu, 18 Apr 2019 20:33:21 -0400 In-Reply-To: <20190412094829.15868-1-colin.king@canonical.com> (Colin King's message of "Fri, 12 Apr 2019 10:48:29 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9231 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=974 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904190001 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9231 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904190001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > Currently the qedf_dbg_* family of functions can overrun the end of > the source string if it is less than the destination buffer length > because of the use of a fixed sized memcpy. Remove the memset/memcpy > calls to nfunc and just use func instead as it is always a null > terminated string. Applied to 5.2/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering