Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: linux-next: build warning after merge of the block tree
To:     Jaegeuk Kim <jaegeuk@kernel.org>
CC:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Jens Axboe <axboe@kernel.dk>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>
References: <20190417123125.3de22f73@canb.auug.org.au>
 <0879e11b-c84c-65b8-581f-bf7adcb5e231@huawei.com>
 <20190417140305.GB23731@jaegeuk-macbookpro.roam.corp.google.com>
 <b1fcb057-6d89-9846-766b-dd1b710f7654@huawei.com>
 <20190418140104.GA52314@jaegeuk-macbookpro.roam.corp.google.com>
From:   Chao Yu <yuchao0@huawei.com>
Message-ID: <b2bc71fb-c11e-8939-daea-facbb5980742@huawei.com>
Date:   Fri, 19 Apr 2019 09:14:06 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190418140104.GA52314@jaegeuk-macbookpro.roam.corp.google.com>
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019/4/18 22:01, Jaegeuk Kim wrote:
> On 04/18, Chao Yu wrote:
>> On 2019/4/17 22:03, Jaegeuk Kim wrote:
>>> On 04/17, Chao Yu wrote:
>>>> Hi Jaegeuk,
>>>>
>>>> On 2019/4/17 10:31, Stephen Rothwell wrote:
>>>>> Hi all,
>>>>>
>>>>> After merging the block tree, today's linux-next build (x86_64
>>>>> allmodconfig) produced this warning:
>>>>>
>>>>> fs/f2fs/node.c: In function 'f2fs_remove_inode_page':
>>>>> fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=]
>>>>>     "Inconsistent i_blocks, ino:%lu, iblocks:%zu",
>>>>>                                              ~~^
>>>>>                                              %llu
>>>>>     inode->i_ino, inode->i_blocks);
>>>>>                   ~~~~~~~~~~~~~~~       
>>>>
>>>> Could you please help to fix that as below in your dev branch directly?
>>>>
>>>> "Inconsistent i_blocks, ino:%lu, iblocks:%llu",
>>>
>>> We can just use "%lu"?
>>
>> We'd better follow sample in Documentation/core-api/printk-formats.rst:
>>
>> If <type> is dependent on a config option for its size (e.g., sector_t,
>> blkcnt_t) or is architecture-dependent for its size (e.g., tcflag_t), use a
>> format specifier of its largest possible type and explicitly cast to it.
> 
> Great, done. :)

Thanks, :)

> 
> Thanks,
> 
>>
>> Example::
>>
>>         printk("test: sector number/total blocks: %llu/%llu\n",
>>                 (unsigned long long)sector, (unsigned long long)blockcount);
>>
>> Thanks,
>>
>>>
>>>> inode->i_ino, (unsigned long long)inode->i_blocks)
>>>>
>>>>
>>>> It looks that we need to fix below commits as well:
>>>>
>>>> f2fs: fix to avoid panic in dec_valid_block_count()
>>>> f2fs: fix to avoid panic in dec_valid_node_count()
>>>>
>>>> Thanks,
>>>>
>>>>>
>>>>> Introduced by commit
>>>>>
>>>>>   90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")
>>>>>
>>>>> from the f2fs tree interacting with commit
>>>>>
>>>>>   72deb455b5ec ("block: remove CONFIG_LBDAF")
>>>>>
>>> .
>>>
> .
>