Received: by 2002:a17:90a:c8b:0:0:0:0 with SMTP id v11csp2290470pja; Fri, 19 Apr 2019 11:22:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRgLmGT+3z2vR94+JOoxPAZeWLg2s7I2e2GuExlZtJ9JjECErl2/o/5wwskVW3OIAmmsD+ X-Received: by 2002:a63:fb4d:: with SMTP id w13mr5265848pgj.397.1555698160743; Fri, 19 Apr 2019 11:22:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555698160; cv=none; d=google.com; s=arc-20160816; b=OA+C79FfhG+X1m+q5TaOT+W2IWd9apL7cFnKqO4Efv/psqHFKBpNZumFyxXMYxDp4K TGpRqAp6jq2cWbKEfIZiu0KcJy95kSJc/OycTjppoLRVYIZKhkxfL8jtEVdkrb9beuHg SnlguI/LEMPr7WORZ8Ex4UTnXEyBwI92KqGAijqYZzELZptIo3j1pt6wsxLwYLBfZLZw pZQZ3HTyECsJNsdKsg8djiiW/Fqdfw3yTiYaJnlIaO+NKzLBWk7GIdafwCsVx1VvHWZc WiGB+UhP6s6WAMfAV0+MhV7T3QGku0Ars16GV0ZeeqRuDzerEGUejrcJ4CQaja6kKZDi 3ezw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CR0l63MsMkbpSElEofDsa9+rQQWzCQ5B3utGWeqKvco=; b=deEl4mkvgEcJPdHRqLTMKndXFSMkMidrBQ9nx9jKTjLu+A/RZCgXqD1taA1Pczz4H+ Bb5WLMcTKxt4exjHMB+3CsAtkW6Tpvs9GU2eSp4Dx89OQe/eOuckU1LfwF6gNSAPeFVv Ax4ynsd8W+NTbMPSe58YHeJ3lJ0eO/VezbJZ7Fx8ie9q29+FdtAi4wK5GOvBez92MxQp RV9ju8jZCHTUO30qF3m/V9pOdOPkRkmMsy794WdBXoZ9ZS6h3ETs5EhGa3erQ8L7otLt rwKvoEjO2QvMxyLqCFnNsFY22BKqwDBZRNm3F+ueWNGGFGrqh9D/hUHdRPnhS4RSh4/R JbcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=TuVsJDeY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i14si5471431pgb.0.2019.04.19.11.22.25; Fri, 19 Apr 2019 11:22:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=TuVsJDeY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727761AbfDSSVi (ORCPT + 99 others); Fri, 19 Apr 2019 14:21:38 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:38528 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727378AbfDSSVh (ORCPT ); Fri, 19 Apr 2019 14:21:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CR0l63MsMkbpSElEofDsa9+rQQWzCQ5B3utGWeqKvco=; b=TuVsJDeYTMOrdR3CxkNl30bQ1 hpRroV5TZAolAnMG18k9U7TGYcmLHVfcPcjc75G3RsLVzrloIwlRHGUpT06dmQ46QfwrVGxnQzxfD 4MsEcqkkhI0Skn1hsFAxwA4d3UGFKUOYWrTzYwjCTtB6m88HwPXE1oA8TVqx2ezT6KaZc=; Received: from 188.29.164.213.threembb.co.uk ([188.29.164.213] helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hHVO0-0008Io-Ox; Fri, 19 Apr 2019 15:25:08 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 35253441D3B; Fri, 19 Apr 2019 16:25:07 +0100 (BST) Date: Fri, 19 Apr 2019 16:25:07 +0100 From: Mark Brown To: "S.j. Wang" Cc: "timur@kernel.org" , "nicoleotsuka@gmail.com" , "Xiubo.Lee@gmail.com" , "festevam@gmail.com" , "alsa-devel@alsa-project.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [alsa-devel] [PATCH V2] ASoC: fsl_esai: Add pm runtime function Message-ID: <20190419152507.GU2803@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4WCFFtl4AQpQKunj" Content-Disposition: inline In-Reply-To: X-Cookie: Shah, shah! Ayatollah you so! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4WCFFtl4AQpQKunj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 19, 2019 at 11:01:21AM +0000, S.j. Wang wrote: > > fsl_esai_probe(struct platform_device *pdev) > > return ret; > > } > >=20 > > + pm_runtime_enable(&pdev->dev); > > + > I just have a question, do I need to add pm_runtime_idle(&pdev->dev)? It gets used to help drivers get into the correct state on startup, if you're unsure if it's 100% required it shouldn't hurt. --4WCFFtl4AQpQKunj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAly56FIACgkQJNaLcl1U h9CGCwf/V4SKmPiu420k0g+uofTrLtN6Jv9aTQuGhf7zO7AX1stWXlkVwZwj6RZK XC7w1TLKHMVSJUp+U5nUKH9lrbIPsldykON2Mn1cK7TQRIXMXoXgZgBZRagddQkU iP0RupSAma6LT4/o4RHV6pjp2qDMU8oJfIUcBqiyFQsmaEMvYK14izz7hOScKwIb VZMnFG60t8T7AxVCKda6cW72ikkuV1pvAENJ2j36iTNfaFA9Ufo/du99PNZK+9bW o34ZkH1FrcKZRgM0gQ3icbYUxQQV+WflxfFayC4M/qfCXjJiVoAbvEpLzfSSVYtW Irvy3o+JKq311kA8vioI3gdp9HFhUg== =6lYl -----END PGP SIGNATURE----- --4WCFFtl4AQpQKunj--