Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 19 Apr 2019 09:32:29 -0400
From:   Sasha Levin <sashal@kernel.org>
To:     nobuhiro1.iwamatsu@toshiba.co.jp
Cc:     gregkh@linuxfoundation.org, stable@vger.kernel.org,
        rdunlap@infradead.org, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5.0 19/93] paride/pcd: cleanup queues when detection fails
Message-ID: <20190419133229.GD17719@sasha-vm>
References: <20190418160436.781762249@linuxfoundation.org>
 <20190418160438.746819159@linuxfoundation.org>
 <TYAPR01MB418948D3F208E92CB2C6B32692270@TYAPR01MB4189.jpnprd01.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <TYAPR01MB418948D3F208E92CB2C6B32692270@TYAPR01MB4189.jpnprd01.prod.outlook.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Apr 19, 2019 at 07:13:07AM +0000, nobuhiro1.iwamatsu@toshiba.co.jp wrote:
>Hi,
>
>> [ Upstream commit 81b74ac68c28fddb3589ad5d4d5e587baf4bb781 ]
>>
>> The driver allocates queues for all the units it potentially
>> supports. But if we fail to detect any drives, then we fail
>> loading the module without cleaning up those queues. This is
>> now evident with the switch to blk-mq, though the bug has
>> been there forever as far as I can tell.
>>
>> Also fix cleanup through regular module exit.
>>
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> Tested-by: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>This commit causes a new problem. And the commit that made the fix
>is f0d1762554014ce0ae347b9f0d088f2c157c8c72.
>I think this commit needs to be applied together.

Queued up this fix, thanks!

--
Thanks,
Sasha