Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 19 Apr 2019 15:11:26 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Okash Khawaja <okash.khawaja@gmail.com>
Cc:     Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Gregory Nowak <greg@gregn.net>, linux-kernel@vger.kernel.org,
        devel@driverdev.osuosl.org, Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
        Peter Hurley <peter@hurleysoftware.com>,
        Kirk Reiser <kirk@reisers.ca>, speakup@linux-speakup.org,
        Jiri Slaby <jslaby@suse.com>,
        John Covici <covici@ccs.covici.com>,
        Ben Hutchings <ben@decadent.org.uk>,
        Chris Brannon <chris@the-brannons.com>
Subject: Re: [PATCH v2 0/2] staging: speakup: factor out selection code
Message-ID: <20190419131126.GA23752@kroah.com>
References: <20190404194530.1170-1-okash.khawaja@gmail.com>
 <1555503674-8219-1-git-send-email-okash.khawaja@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1555503674-8219-1-git-send-email-okash.khawaja@gmail.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 17, 2019 at 01:21:12PM +0100, Okash Khawaja wrote:
> Hi,
> 
> The v2 renames set_selection() and do_set_selection() to following 
> more explicit names:
> 
> set_selection_user() /* includes copying data from user space */
> set_selection_kernel() /* no copying from user space */
> 
> The patches also update references to set_selection() to be 
> set_selection_user().
> 
> Original intro:
> 
> Speakup's selection functionality parallels that of  
> drivers/tty/vt/selection.c. This patch set replaces speakup's
> implementation with calls to vt's selection code. This is one of the
> remaining items in our TODO file and it's needed for moving speakup out
> of staging.
> 
> Please note that in speakup selection is set inside interrupt context of
> keyboard handler. Set selection code in vt happens in process context
> and hence expects ability to sleep. To address this, there were two
> options: farm out speakup's set selection into a work_struct thread, or
> create atomic version of vt's set_selection. These patches implement
> the former option.

Very nice, both now queued up!

thanks,

greg k-h