Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2102738yba; Fri, 19 Apr 2019 12:10:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqzaqqbOBjNtTLzv3rKQwyNhCyIvA62sY4gBHZ5fi9We3KZxj82DLnQdCTyGlWHLL5HmKUCP X-Received: by 2002:a63:7949:: with SMTP id u70mr5374806pgc.418.1555701023389; Fri, 19 Apr 2019 12:10:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555701023; cv=none; d=google.com; s=arc-20160816; b=pASd9V2WW/OxvEw5U45wF2OehW55J8fWbebFhOcnANC39N3aWyohF9/2WqTGTtw626 CitSMkS5wsrOg5LWp87MSmoX07qbtI0V3co+XndOJFDN+VdTSEP43BGzIg+UB0OCpRQv FaXmHdtP5euWoqW1hyfDFFiiiK//OP7fMVf69UJLgoM3mM5l2kmzkdgGAaLOLMRDXw2d qSFebypCINDMh5mKvxKt4PW0G28IuJdodbWnPDZT5OPUdOHujm8KSs4m5BgJZ0kuoWSA 4Fiznr5uG/82tefveiEsR65DYGaWyl4AAAcgBRKpq/Mm95gt413IvbaQS6ioXjldkko+ 9JMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eOp/ySOqHIMhpte/mJe3u1Zx4rYSYksGeMB7N2WQHHk=; b=AIlzTSkNazwVZ32fa4YqcRo4h8b0Rfq0QvV1zRx8TcCHRwJDwcrwOVyGr7dnpYPizf qtNPk1ku0R180g2UUj/MQ1XrtSUHS07geYZPCpYIttQyI/lIdWwCrLS1qqYIF6SZOkuX eZM5iZ4HZehhWOpMdgPiDXhL0Sd05Tl9t6OzfrwR3i0UlfsTzCirHEee0tS8a5rKJjZk N7R/kZa7JkdQrL2jrbUqGXBfgL+56Yt/fDrFrwbLNDvQ9Wb+Hgxl/I3K4jQjOEsFxEHH VJUyRyi3jztd97cIgTeK37Qn8fJ4dJBqc+6i8wlw5CF8+ibJ09vhoQariL1BLgOXmWzo 1PuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=KvSUr3dZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t185si5475097pgd.485.2019.04.19.12.10.08; Fri, 19 Apr 2019 12:10:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=KvSUr3dZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729786AbfDSTJE (ORCPT + 99 others); Fri, 19 Apr 2019 15:09:04 -0400 Received: from mail.skyhub.de ([5.9.137.197]:42186 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727924AbfDSTJC (ORCPT ); Fri, 19 Apr 2019 15:09:02 -0400 Received: from zn.tnic (p200300EC2F112E0081C1838BC39E212C.dip0.t-ipconnect.de [IPv6:2003:ec:2f11:2e00:81c1:838b:c39e:212c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 261A21EC0513; Fri, 19 Apr 2019 16:19:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1555683598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=eOp/ySOqHIMhpte/mJe3u1Zx4rYSYksGeMB7N2WQHHk=; b=KvSUr3dZjOYEW2cN7Z7qdy1pvJR4XtfLReq6g0Mpo/ceNzhES0cByjesayV3ajJm8IQLsl gc0ul2nUCYDTShPum8+7PY3yANpcrLg5Lul9sM9vN3i70sQuyNUx6m/euxFXQp503333CC He51Jt9MdDESEfOK2c4PtnceiCcCUG8= Date: Fri, 19 Apr 2019 16:19:52 +0200 From: Borislav Petkov To: Kairui Song , Thomas Gleixner Cc: Baoquan He , Linux Kernel Mailing List , Junichi Nomura , Dave Young , Chao Fan , "x86@kernel.org" , "kexec@lists.infradead.org" , Ard Biesheuvel , Dave Hansen , "H. Peter Anvin" , indou.takao@jp.fujitsu.com, Ingo Molnar , Juergen Gross , Kees Cook , "Kirill A. Shutemov" , msys.mizuma@gmail.com, Tom Lendacky Subject: [PATCH] x86/boot: Disable RSDP parsing temporarily Message-ID: <20190419141952.GE10324@zn.tnic> References: <20190419101733.GA10324@zn.tnic> <20190419105014.GE11060@MiWiFi-R3L-srv> <20190419113413.GC10324@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ok, thinking about this more, we believe it is too late in the release cycle to keep experimenting so the only thing left to do is the below. This should bring the situation back to what it was before, at 5.0 times, and we'll have plenty of time now to address and properly fix all the outstanding issues. --- From: Borislav Petkov The original intention to move RDSP parsing very early, before KASLR does its ranges selection, was to accommodate movable memory regions machines (CONFIG_MEMORY_HOTREMOVE) to still be able to do memory hotplug. However, that broke kexec'ing a kernel on EFI machines because depending on where the EFI systab was mapped, on at least one machine it isn't present in the kexec mapping of the second kernel, leading to a triple fault in the early code. Fixing this properly requires significantly involved surgery and we cannot allow ourselves to do that, that close to the merge window. So disable the RSDP parsing code temporarily until it is fixed properly in the next release cycle. Signed-off-by: Borislav Petkov Cc: Ard Biesheuvel Cc: Baoquan He Cc: Chao Fan Cc: Dave Hansen Cc: "H. Peter Anvin" Cc: indou.takao@jp.fujitsu.com Cc: Ingo Molnar Cc: Juergen Gross Cc: kasong@redhat.com Cc: Kees Cook Cc: "Kirill A. Shutemov" Cc: msys.mizuma@gmail.com Cc: Thomas Gleixner Cc: Tom Lendacky Cc: x86-ml --- arch/x86/boot/compressed/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c index c0d6c560df69..5a237e8dbf8d 100644 --- a/arch/x86/boot/compressed/misc.c +++ b/arch/x86/boot/compressed/misc.c @@ -352,7 +352,7 @@ asmlinkage __visible void *extract_kernel(void *rmode, memptr heap, boot_params->hdr.loadflags &= ~KASLR_FLAG; /* Save RSDP address for later use. */ - boot_params->acpi_rsdp_addr = get_rsdp_addr(); + /* boot_params->acpi_rsdp_addr = get_rsdp_addr(); */ sanitize_boot_params(boot_params); -- 2.21.0 -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.