Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 19 Apr 2019 09:56:10 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Waiman Long <longman@redhat.com>
Cc:     Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        Davidlohr Bueso <dave@stgolabs.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        huang ying <huang.ying.caritas@gmail.com>
Subject: Re: [PATCH v4 12/16] locking/rwsem: Enable time-based spinning on
 reader-owned rwsem
Message-ID: <20190419075610.GN4038@hirez.programming.kicks-ass.net>
References: <20190413172259.2740-1-longman@redhat.com>
 <20190413172259.2740-13-longman@redhat.com>
 <20190418130611.GK4038@hirez.programming.kicks-ass.net>
 <52aee7c3-b8aa-a617-c1f2-34bc99c72474@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52aee7c3-b8aa-a617-c1f2-34bc99c72474@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 18, 2019 at 11:15:33AM -0400, Waiman Long wrote:
> On 04/18/2019 09:06 AM, Peter Zijlstra wrote:

> >> +			/*
> >> +			 * Check time threshold every 16 iterations to
> >> +			 * avoid calling sched_clock() too frequently.
> >> +			 * This will make the actual spinning time a
> >> +			 * bit more than that specified in the threshold.
> >> +			 */
> >> +			else if (!(++loop & 0xf) &&
> >> +				 (sched_clock() > rspin_threshold)) {
> > Why is calling sched_clock() lots a problem?
> 
> Actually I am more concern about the latency introduced by the
> sched_clock() call. BTW, I haven't done any measurement myself. Do you
> know how much cost the sched_clock() call is?
> 
> If the cost is relatively high, the average latency period after the
> lock is free and the spinner is ready to do a trylock will increase.

Totally depends on the arch or course :/ For 'sane' x86 it is: RDTSC,
MUL; SHRD; SHR; ADD, which is plenty fast.

I know we have poll loops with sched_clock/local_clock in them, I just
can't seem to find any atm.