Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Jarzmik <robert.jarzmik@free.fr>
To:     Zhou Wang <wangzhou1@hisilicon.com>
Cc:     <axboe@fb.com>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>
Subject: Re: [PATCH] lib: scatterlist: Fix to support no mapped sg
References: <1555581006-153458-1-git-send-email-wangzhou1@hisilicon.com>
Date:   Fri, 19 Apr 2019 12:43:19 +0200
In-Reply-To: <1555581006-153458-1-git-send-email-wangzhou1@hisilicon.com>
        (Zhou Wang's message of "Thu, 18 Apr 2019 17:50:06 +0800")
Message-ID: <871s1ymg1k.fsf@belgarion.home>
User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Zhou Wang <wangzhou1@hisilicon.com> writes:

> In function sg_split, the second sg_calculate_split will return -EINVAL
> when in_mapped_nents is 0.
>
> Indeed there is no need to do second sg_calculate_split and sg_split_mapped
> when in_mapped_nents is 0, as in_mapped_nents indicates no mapped entry in
> original sgl.
>
> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
That's right. May I know what is the usecase which led you to this fix ?

Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

--
Robert