Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 19 Apr 2019 13:58:30 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Joe Perches <joe@perches.com>
Cc:     Masahiro Yamada <yamada.masahiro@socionext.com>,
        Douglas Anderson <dianders@chromium.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Jason Wessel <jason.wessel@windriver.com>,
        Christophe Leroy <christophe.leroy@c-s.fr>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Kees Cook <keescook@chromium.org>,
        kgdb-bugreport@lists.sourceforge.net,
        Johannes Weiner <hannes@cmpxchg.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Nicholas Mc Guire <hofrat@osadl.org>
Subject: Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in
 kdb summary
Message-Id: <20190419135830.0e3273e223fb83947e5adb0d@linux-foundation.org>
In-Reply-To: <e5f29ca9b6067fff9ea68cb25e15906659cd51ad.camel@perches.com>
References: <20190323015227.245455-1-dianders@chromium.org>
        <CAK7LNARYMy2=viA1et9tZk409M=OSteD5D675oAKQEs6SG77HQ@mail.gmail.com>
        <20190416163034.3e642818ebf27ed6891c1981@linux-foundation.org>
        <CAK7LNAR4Ty8835sfo4HSvBsMCsV65mY2HOajFSY2TOYurmkFdw@mail.gmail.com>
        <20190418160651.40cb6a11186a6c6028e9d20d@linux-foundation.org>
        <CAK7LNAQe2uaVfKee1F6R4siVvUSCMgSaYAnUQfz8MS5PeFqpGA@mail.gmail.com>
        <e5f29ca9b6067fff9ea68cb25e15906659cd51ad.camel@perches.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 19 Apr 2019 04:14:27 -0700 Joe Perches <joe@perches.com> wrote:

> On Fri, 2019-04-19 at 12:28 +0900, Masahiro Yamada wrote:
> > Hi Joe,
> > 
> > Can you detect redundant Cc: by checkpatch?
> > 
> > Please see below in details.
> > Thanks.
> 
> Yes, but I'm not sure why it's useful or necessary.
> git send-email using some scripts elides duplicate email addresses

Other (all?) MUAs will avoid addressing an email to a recipient more
than once.  The issue here is redundant Cc: lines in the changelog.

> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2688,6 +2688,19 @@ sub process {
>  				$signatures{$sig_nospace} = 1;
>  			}
>  
> +# Check for a cc: line with another signature -by: by the same author
> +			if ($sig_nospace =~ /^cc:/) {
> +				my $sig_email = substr($sig_nospace, 3);
> +				foreach my $sig (sort keys %signatures) {
> +					next if ($sig =~ /^cc:/);
> +					$sig =~ s/^[^:]+://;
> +					if ($sig eq $sig_email) {
> +						WARN("BAD_SIGN_OFF",
> +						     "Unnecessary CC: as there is another signature with the same name/email address\n" . $herecurr);
> +					}
> +				}
> +			}
> +
>  # Check Co-developed-by: immediately followed by Signed-off-by: with same name and email
>  			if ($sign_off =~ /^co-developed-by:$/i) {
>  				if ($email eq $author) {

Thanks.  But my checkpatch.pl is different from yours.

q:/usr/src/25> grep "immediately followed by" scripts/checkpatch.pl
q:/usr/src/25>