Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2188661yba; Fri, 19 Apr 2019 14:05:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqwSI3D+oyQPjyHpfzAQOJDudS0XmtSBFDC1HiX0Zh2bclGK4MdiDxlS9VOE7xW1FobO2nAh X-Received: by 2002:a65:6686:: with SMTP id b6mr5929656pgw.419.1555707954551; Fri, 19 Apr 2019 14:05:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555707954; cv=none; d=google.com; s=arc-20160816; b=dyrfN730JhseXSVNBsWl2Mrs8YG5sh9eiMSjJxwTJX3MQr9erL5sBi/u3vlvZL/zbp BAKzEoyd49ypjxi/YUEuVevJKk5cFPl9+95cWg/XWA8gEqGg/+nbramOISVCrurWPfPI NsBvfO0dTqZ/47bWOWDJdWV4AxDdICNL/SXhKx8hvyzEviut0XIJLRMGiIh9VCZaKUEB qVCPgM8LiIduHvCO13Xscj5CL5HbDKif/c82ZdwT+UZvaOmGSNLMiv2tKywbU3YaaZEm cpA7qPuQdEmHkcXmLXzIDjKtDYAMdPw5lsJU25+hZJRZIOUaFcTaIIQzam+sgikpUYmq mdzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=T6L/3SHst05vC8yOgMlzjsRIbhRS9KrakWKP5A8GJoc=; b=gmoBPA0GR5gxBwTPk2VupXW66FtanI7VoJrTOSYEKgc3qaD8M6CnFa4qb4H5OJ1qPB u52hgTayRV374zfWntdGNNlc2+Xtj6MsZGmjoQw7wVmPn2mwwA+mzIMDJJgklwOu3nXY SmM0+F9J5x3e51AGZ8Q4qSKFCg7SKpxM0xEAB/2InNEMvH5nCceNJHFTLX+xyjvClvfO 3R+4aQbI/WRmXjXGHa6dWL5Nl+L34s+a8bXxwfp3yViosd22uG6tUtyUwfyOAOX6Nqv4 e7+jyTxJCjYuGTTBGZgxHvTWvwkecdoL9j33uY5aW6SiTfqjM7+I4/63wDFniOSEnGhm +ryQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=Ky+hF2vS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 17si5863205pgk.72.2019.04.19.14.05.39; Fri, 19 Apr 2019 14:05:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=Ky+hF2vS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727631AbfDSVEr (ORCPT + 99 others); Fri, 19 Apr 2019 17:04:47 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:48210 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbfDSVEq (ORCPT ); Fri, 19 Apr 2019 17:04:46 -0400 Received: from pps.filterd (m0109333.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3JKtfjB005451; Fri, 19 Apr 2019 14:04:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : mime-version : content-type : content-transfer-encoding; s=facebook; bh=T6L/3SHst05vC8yOgMlzjsRIbhRS9KrakWKP5A8GJoc=; b=Ky+hF2vS0rtHMq9kbL3Om3jMhbIozMY/4r0gAn1grHb8O59NYH3VqPUOQkVHpe2C3akF zgbKZmZHiGEsc6sMHfY5IMD0yCYXKVesuzgLmG4mcKNTnwhk6UYY3YF+NGikQ72zXfC5 jwfZRKSpq73z3OQkgJjT39KMiwhh4vk8H5w= Received: from mail.thefacebook.com (mailout.thefacebook.com [199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 2ryjv7gyqh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 19 Apr 2019 14:04:26 -0700 Received: from mmullins-1.thefacebook.com (2620:10d:c081:10::13) by mail.thefacebook.com (2620:10d:c081:35::127) with Microsoft SMTP Server id 15.1.1713.5; Fri, 19 Apr 2019 14:04:25 -0700 From: Matt Mullins To: , , , , CC: , Daniel Borkmann , Martin KaFai Lau , Song Liu , "Yonghong Song" Subject: [PATCH bpf-next v3 0/5] writable contexts for bpf raw tracepoints Date: Fri, 19 Apr 2019 14:04:04 -0700 Message-ID: <20190419210409.5021-1-mmullins@fb.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [2620:10d:c081:10::13] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-19_12:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This adds an opt-in interface for tracepoints to expose a writable context to BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE programs that are attached, while supporting read-only access from existing BPF_PROG_TYPE_RAW_TRACEPOINT programs, as well as from non-BPF-based tracepoints. The initial motivation is to support tracing that can be observed from the remote end of an NBD socket, e.g. by adding flags to the struct nbd_request header. Earlier attempts included adding an NBD-specific tracepoint fd, but in code review, I was recommended to implement it more generically -- as a result, this patchset is far simpler than my initial try. v2->v3: * Andrew addressed Josef's comments: * C-style commenting in nbd.c * Collapsed identical events into a single DECLARE_EVENT_CLASS. This saves about 2kB of kernel text v1->v2: * add selftests * sync tools/include/uapi/linux/bpf.h * reject variable offset into the buffer * add string representation of PTR_TO_TP_BUFFER to reg_type_str Andrew Hall (1): nbd: add tracepoints for send/receive timing Matt Mullins (4): bpf: add writable context for raw tracepoints nbd: trace sending nbd requests tools: sync bpf.h selftests: bpf: test writable buffers in raw tps MAINTAINERS | 1 + drivers/block/nbd.c | 13 +++ include/linux/bpf.h | 2 + include/linux/bpf_types.h | 1 + include/linux/tracepoint-defs.h | 1 + include/trace/bpf_probe.h | 27 ++++- include/trace/events/bpf_test_run.h | 50 ++++++++ include/trace/events/nbd.h | 107 ++++++++++++++++++ include/uapi/linux/bpf.h | 1 + kernel/bpf/syscall.c | 8 +- kernel/bpf/verifier.c | 31 +++++ kernel/trace/bpf_trace.c | 21 ++++ net/bpf/test_run.c | 4 + tools/include/uapi/linux/bpf.h | 1 + tools/lib/bpf/libbpf.c | 1 + tools/lib/bpf/libbpf_probes.c | 1 + .../raw_tp_writable_reject_nbd_invalid.c | 40 +++++++ .../bpf/prog_tests/raw_tp_writable_test_run.c | 80 +++++++++++++ .../selftests/bpf/verifier/raw_tp_writable.c | 34 ++++++ 19 files changed, 420 insertions(+), 4 deletions(-) create mode 100644 include/trace/events/bpf_test_run.h create mode 100644 include/trace/events/nbd.h create mode 100644 tools/testing/selftests/bpf/prog_tests/raw_tp_writable_reject_nbd_invalid.c create mode 100644 tools/testing/selftests/bpf/prog_tests/raw_tp_writable_test_run.c create mode 100644 tools/testing/selftests/bpf/verifier/raw_tp_writable.c -- 2.17.1