Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2206455yba; Fri, 19 Apr 2019 14:29:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqzgKJMF0J1eMqbIhbdy0H2rTPY44+I5nZV78uqRaI8KlTVrr0tnq6g+uK5GehpluxhNurtq X-Received: by 2002:a65:608a:: with SMTP id t10mr5989934pgu.125.1555709355656; Fri, 19 Apr 2019 14:29:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555709355; cv=none; d=google.com; s=arc-20160816; b=DdH0U4UCBRodZ9fq44K9WpYri8FwmsOQFoMdugur2iE72GPRBIfJhW9bSJtaNMkTUM eGeh0O6dbXwPFFIj6fMQHQ2gIxWxJkB80oZdgva0R5PhXxUaPegBeyUlcA2ZrVDbvVV8 BTcEzbDfExIKr1Umfaxi7pFhktYXlr1bDdu2JVog9gPlreLhWtzrn8oATfeKfKHUb6Hv ZsZJQ8u6rjA9hjrSKdlazgRXr5JQNfidrnQFpj7YvyJIPsSy+G7Gz0M7DRmTT14s7Pjg Eorli9Msbf91iIDWKXS5EqL7UCR7wgKED11VfJ8Aw+lOk8ciLdavetlzUba3WfUqoIce j2gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=9f7CdBA6zWS9yVHWaR88eHHEio8HE+2M/lu588dE/9E=; b=cOpZA0DnLgHEx2wRygu/QjNSNpjfVHPA7JQWA8dVNfmMchoP92ya7zRrADRij1+ZLf JCQ3S3lyORG7NuL1dHdtSD9xe/kDJsOsy6kv/5EPcLLA63bZNdWVe95domcj9wRe//1S UEN+JfgvK/3ZOBEOJda7++uJwdYsm3i0PHpPzOK56qrJkryKrPMMOunJDW1YcLPv4tbL gco1eF/IogoGQ/ukeCb3tGpa9FA8agrxt6XXkvO7sRhRcGzcwUhyoqZQsp1owKBuhm/i Ye49p8YL/Lg4UchiJTjpVRjQKARxsIlgovArKmRZZr0ly4G19ma3L/rNkzLc2jAi+w0C qpHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j10si6054797plb.346.2019.04.19.14.28.57; Fri, 19 Apr 2019 14:29:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727550AbfDSV1c (ORCPT + 99 others); Fri, 19 Apr 2019 17:27:32 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:46961 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbfDSV1c (ORCPT ); Fri, 19 Apr 2019 17:27:32 -0400 Received: from [192.168.1.164] ([37.4.249.100]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MMXYH-1haUdG0Mat-00Jclw; Fri, 19 Apr 2019 13:34:05 +0200 Subject: Re: [PATCH V2] staging: vc04_services: handle kzalloc failure To: Nicholas Mc Guire , Eric Anholt Cc: Greg Kroah-Hartman , Dominic Braun , Tobias Buettner , Nicolas Saenz Julienne , Luis Chamberlain , Phil Elwell , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1555630268-17017-1-git-send-email-hofrat@osadl.org> From: Stefan Wahren Openpgp: preference=signencrypt Autocrypt: addr=stefan.wahren@i2se.com; keydata= xsFNBFt6gBMBEACub/pBevHxbvJefyZG32JINmn2bsEPX25V6fejmyYwmCGKjFtL/DoUMEVH DxCJ47BMXo344fHV1C3AnudgN1BehLoBtLHxmneCzgH3KcPtWW7ptj4GtJv9CQDZy27SKoEP xyaI8CF0ygRxJc72M9I9wmsPZ5bUHsLuYWMqQ7JcRmPs6D8gBkk+8/yngEyNExwxJpR1ylj5 bjxWDHyYQvuJ5LzZKuO9LB3lXVsc4bqXEjc6VFuZFCCk/syio/Yhse8N+Qsx7MQagz4wKUkQ QbfXg1VqkTnAivXs42VnIkmu5gzIw/0tRJv50FRhHhxpyKAI8B8nhN8Qvx7MVkPc5vDfd3uG YW47JPhVQBcUwJwNk/49F9eAvg2mtMPFnFORkWURvP+G6FJfm6+CvOv7YfP1uewAi4ln+JO1 g+gjVIWl/WJpy0nTipdfeH9dHkgSifQunYcucisMyoRbF955tCgkEY9EMEdY1t8iGDiCgX6s 50LHbi3k453uacpxfQXSaAwPksl8MkCOsv2eEr4INCHYQDyZiclBuuCg8ENbR6AGVtZSPcQb enzSzKRZoO9CaqID+favLiB/dhzmHA+9bgIhmXfvXRLDZze8po1dyt3E1shXiddZPA8NuJVz EIt2lmI6V8pZDpn221rfKjivRQiaos54TgZjjMYI7nnJ7e6xzwARAQABzSlTdGVmYW4gV2Fo cmVuIDxzdGVmYW4ud2FocmVuQGluLXRlY2guY29tPsLBdwQTAQgAIQUCXIdehwIbAwULCQgH AgYVCAkKCwIEFgIDAQIeAQIXgAAKCRCUgewPEZDy2yHTD/9UF7QlDkGxzQ7AaCI6N95iQf8/ 1oSUaDNu2Y6IK+DzQpb1TbTOr3VJwwY8a3OWz5NLSOLMWeVxt+osMmlQIGubD3ODZJ8izPlG /JrNt5zSdmN5IA5f3esWWQVKvghZAgTDqdpv+ZHW2EmxnAJ1uLFXXeQd3UZcC5r3/g/vSaMo 9xek3J5mNuDm71lEWsAs/BAcFc+ynLhxwBWBWwsvwR8bHtJ5DOMWvaKuDskpIGFUe/Kb2B+j ravQ3Tn6s/HqJM0cexSHz5pe+0sGvP+t9J7234BFQweFExriey8UIxOr4XAbaabSryYnU/zV H9U1i2AIQZMWJAevCvVgQ/U+NeRhXude9YUmDMDo2sB2VAFEAqiF2QUHPA2m8a7EO3yfL4rM k0iHzLIKvh6/rH8QCY8i3XxTNL9iCLzBWu/NOnCAbS+zlvLZaiSMh5EfuxTtv4PlVdEjf62P +ZHID16gUDwEmazLAMrx666jH5kuUCTVymbL0TvB+6L6ARl8ANyM4ADmkWkpyM22kCuISYAE fQR3uWXZ9YgxaPMqbV+wBrhJg4HaN6C6xTqGv3r4B2aqb77/CVoRJ1Z9cpHCwiOzIaAmvyzP U6MxCDXZ8FgYlT4v23G5imJP2zgX5s+F6ACUJ9UQPD0uTf+J9Da2r+skh/sWOnZ+ycoHNBQv ocZENAHQf87BTQRbeoATARAA2Hd0fsDVK72RLSDHby0OhgDcDlVBM2M+hYYpO3fX1r++shiq PKCHVAsQ5bxe7HmJimHa4KKYs2kv/mlt/CauCJ//pmcycBM7GvwnKzmuXzuAGmVTZC6WR5Lk akFrtHOzVmsEGpNv5Rc9l6HYFpLkbSkVi5SPQZJy+EMgMCFgjrZfVF6yotwE1af7HNtMhNPa LDN1oUKF5j+RyRg5iwJuCDknHjwBQV4pgw2/5vS8A7ZQv2MbW/TLEypKXif78IhgAzXtE2Xr M1n/o6ZH71oRFFKOz42lFdzdrSX0YsqXgHCX5gItLfqzj1psMa9o1eiNTEm1dVQrTqnys0l1 8oalRNswYlQmnYBwpwCkaTHLMHwKfGBbo5dLPEshtVowI6nsgqLTyQHmqHYqUZYIpigmmC3S wBWY1V6ffUEmkqpAACEnL4/gUgn7yQ/5d0seqnAq2pSBHMUUoCcTzEQUWVkiDv3Rk7hTFmhT sMq78xv2XRsXMR6yQhSTPFZCYDUExElEsSo9FWHWr6zHyYcc8qDLFvG9FPhmQuT2s9Blx6gI 323GnEq1lwWPJVzP4jQkJKIAXwFpv+W8CWLqzDWOvdlrDaTaVMscFTeH5W6Uprl65jqFQGMp cRGCs8GCUW13H0IyOtQtwWXA4ny+SL81pviAmaSXU8laKaRu91VOVaF9f4sAEQEAAcLBXwQY AQIACQUCW3qAEwIbDAAKCRCUgewPEZDy2+oXD/9cHHRkBZOfkmSq14Svx062PtU0KV470TSn p/jWoYJnKIw3G0mXIRgrtH2dPwpIgVjsYyRSVMKmSpt5ZrDf9NtTbNWgk8VoLeZzYEo+J3oP qFrTMs3aYYv7e4+JK695YnmQ+mOD9nia915tr5AZj95UfSTlyUmyic1d8ovsf1fP7XCUVRFc RjfNfDF1oL/pDgMP5GZ2OwaTejmyCuHjM8IR1CiavBpYDmBnTYk7Pthy6atWvYl0fy/CqajT Ksx7+p9xziu8ZfVX+iKBCc+He+EDEdGIDhvNZ/IQHfOB2PUXWGS+s9FNTxr/A6nLGXnA9Y6w 93iPdYIwxS7KXLoKJee10DjlzsYsRflFOW0ZOiSihICXiQV1uqM6tzFG9gtRcius5UAthWaO 1OwUSCQmfCOm4fvMIJIA9rxtoS6OqRQciF3crmo0rJCtN2awZfgi8XEif7d6hjv0EKM9XZoi AZYZD+/iLm5TaKWN6oGIti0VjJv8ZZOZOfCb6vqFIkJW+aOu4orTLFMz28aoU3QyWpNC8FFm dYsVua8s6gN1NIa6y3qa/ZB8bA/iky59AEz4iDIRrgUzMEg8Ak7Tfm1KiYeiTtBDCo25BvXj bqsyxkQD1nkRm6FAVzEuOPIe8JuqW2xD9ixGYvjU5hkRgJp3gP5b+cnG3LPqquQ2E6goKUML AQ== Message-ID: <80087aaa-eea6-6258-341e-17814a210894@i2se.com> Date: Fri, 19 Apr 2019 13:34:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1555630268-17017-1-git-send-email-hofrat@osadl.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Provags-ID: V03:K1:bRhjrVHVmnOVYA0R2HKdh81mEBAtIYXBXSJhUquSXqFeWVo+LxR IMYGXSGXpue2GBdJK/HK41l4a7TFMbd0EJOcFgyLXuh+LSvRAQF2H8lv8PqgYHFGUCL3nxG AaLxEj0dnkxrGyAwKEk+s981SPRtHv3Sw0iTVOTDAIYuF+plf/5WLxjRx9Sctg6xKpm+88/ MHE6fXkZx+s4kZtf8W+EA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:3YkrbTlm6GM=:IwJus+axOuOSELg1s51O8z jRGWunbMjjaQvCyd8Oag6VtmmeW781CDfA+H+SUYjdl+5qRx1wH4sbclebqmw7XFIavDh7MMU Sd2m8jclkkHFhjPPwbejX11CvSl0q7LKK8u25AnMRQ2ouubbFJpWkxYPNVTORhZKc0gWQnHrx 1xMfpVrDaDjbqxjahW0UUX+B/P0rZuhzPv8Atd7v0eLq4/m/mm7v8vTcT6zbT4K8nddXIyPG4 mAUU0Oy59Ctl8IKZxgU2M9fZ3FOjdog+jgOXP80cMTD/xQfudlEwWftLMNjosQNGNJtVi6nmy A7nYiGlcqFKpHVVpaHopIFd9OpGIXl8/nGiJucIQmQvbE2ya+xb+w9VDfZlzzxIUWKO4q3x6u 5uPk/lkw1sIEwYTtW441VuTlAkaC4/w1peFsBRSKXTk0kM6ReDo2KTbLy08KXUIciki5/8cUr TnY122sV6xkjgUlmYeOJyWAXdnp2bwTD6MrkG1H9OeHaYHqr6Cx0OC2dQ6KvyuUVPAhPpgyj4 2KHqHZpwSiqktB6IMitVXSIctqzh4p1VhOrHXoTbUJYpM70i97mYqnCvF/cyVWvY+vEaXXiRB SZvBYpANaEuc9Kow/W3peyHqnfUtbyZkuSVMTiaomcD7YrvlbJ3Tg0N3FpIxyzDtrID9mMi1/ x9xZCliyrDHGBK6wFfh1YAfEK20TbfrUGvJFkhGZJcy/8IhpAK4kmzDh4OOqGDXIkWPi+w1lc aqQvgd2V5e3E5JEy90F28npC6Whxk5EmLje36w4l4T1f9OQVCOyQZleN+6c= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 19.04.19 um 01:31 schrieb Nicholas Mc Guire: > The kzalloc here was being used without checking the return - if the > kzalloc fails return VCHIQ_ERROR. The call-site of > vchiq_platform_init_state() vchiq_init_state() was not responding > to an allocation failure so checks for != VCHIQ_SUCCESS > and pass VCHIQ_ERROR up to vchiq_platform_init() which then > will fail with -EINVAL. > > Signed-off-by: Nicholas Mc Guire > Reported-by: kbuild test robot > --- Acked-By: Stefan Wahren