Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2267729yba; Fri, 19 Apr 2019 15:56:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqz6IGtszGDmp/6EVzh00N07MKxRp02tnTClGNdJ+3TPDfKvE54jyG7noJXDImHy1lBZ+xxF X-Received: by 2002:a62:1d94:: with SMTP id d142mr6607082pfd.83.1555714570076; Fri, 19 Apr 2019 15:56:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555714570; cv=none; d=google.com; s=arc-20160816; b=rKHUN7u7Tf7x6MC7RTPPGxusQvAVwi3F2W7B/emw7KyIq1be3+tQiEAD/rDxvgxXkF 1gLKOmOgxmPvSgGEesRBetYx2srnxNtBpfE1GfVsHiUeWkBpEHC4BAdr0EGk+K8jpD4a FZItYf5j3nwU0RZH0Gt9C2Cx7GlnY0VPEnDbAKpAGuEhS7mUm4d6ZWxJB3c8dMhDpUo6 akOHjZvkcLnXwSt1e2nrmbUlhNQ7h/kb6adjsatIbwHurfcEyvraOcuzACmGY7pqaGh4 5T9ARREdTkhPQITBKYjLduUPpy+TyjLvXJUAAs3+MDSP83o02we+PTfaL8nVnKfJrzHI 5afg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=0Pkxu52DB5IBr5OGBbKFzngS+GfS86DjCSgv6kVsApo=; b=HaxDOtC/rz5cn/k6KnwiQcQyIX2vnfBSS6ilYPZiwYb7XoTQgsSyw6CWaQPqlrz/Ly lzHmdzl/brRboG5kHQBRVjSQusOR/tbfyr697wHnvq5fynL5J7LSds3cdQXEszIj5HIQ CqITW32rJvL0AU1MVnismzrWqX6ERTKAxg3OG38u7/OKqR6UNhStuPOHViHIW1PBJ6QC aST4RtVfoiy7+oPsLmH0RUmnVYb4JX0Uyalh6tuWWD8GDYmrxRRpRfj27m/R8mnDlk/u VVlbl7Rsay783mfT+IIezxbmXOYwc55qjcHbRHFCzBJ4r6AVy6GNi2vjFl73H893oSGM stdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=QQ2igCFD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q13si6167247pls.284.2019.04.19.15.55.55; Fri, 19 Apr 2019 15:56:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=QQ2igCFD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726869AbfDSWyX (ORCPT + 99 others); Fri, 19 Apr 2019 18:54:23 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:49702 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726485AbfDSWyX (ORCPT ); Fri, 19 Apr 2019 18:54:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0Pkxu52DB5IBr5OGBbKFzngS+GfS86DjCSgv6kVsApo=; b=QQ2igCFDXgmj80eLgbpIoDtQg dkebKQqI8jLRgRv//u3TXClaiTuNktF467S0Ik47hrX+T/f7Eqoc3Zl1dz0ctEZ9Me3euzXbXtUor Tl/0mHmz/cAjNv7xxReKyedEAH8ZBFWdwvsFsk+QfWiMts0yBrLBEteTUT4nss7mMqPoCqT8mbe2p STPVmp9iAb9tTbpxWtWPq0zKruhKjTooxvPl6llRedgXGe7z8Weh8vaKNUVJVxQEGkG3YwkKZoII3 +p6q+xFHxWCkac9ZhRIVdJ+g07a7rxa+HqDEru6XXvxfZ0gKQ0KjWnXg/VTYOpOIjudIf/nOTJU9k Xw30PjVAg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHSDZ-0001Nn-Th; Fri, 19 Apr 2019 12:02:10 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 71B5C29BB5803; Fri, 19 Apr 2019 14:02:07 +0200 (CEST) Date: Fri, 19 Apr 2019 14:02:07 +0200 From: Peter Zijlstra To: Waiman Long Cc: Ingo Molnar , Will Deacon , Thomas Gleixner , linux-kernel@vger.kernel.org, x86@kernel.org, Davidlohr Bueso , Linus Torvalds , Tim Chen , huang ying Subject: Re: [PATCH v4 14/16] locking/rwsem: Guard against making count negative Message-ID: <20190419120207.GO4038@hirez.programming.kicks-ass.net> References: <20190413172259.2740-1-longman@redhat.com> <20190413172259.2740-15-longman@redhat.com> <20190418135151.GB12232@hirez.programming.kicks-ass.net> <20190418144036.GE12232@hirez.programming.kicks-ass.net> <4cbd3c18-c9c0-56eb-4e01-ee355a69057a@redhat.com> <20190419102647.GP7905@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190419102647.GP7905@worktop.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 19, 2019 at 12:26:47PM +0200, Peter Zijlstra wrote: > I thought of a horrible horrible alternative: Hurm, that's broken as heck. Let me try again.