Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 20 Apr 2019 12:17:14 +0200
From:   Maxime Chevallier <maxime.chevallier@bootlin.com>
To:     David Miller <davem@davemloft.net>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        antoine.tenart@bootlin.com, thomas.petazzoni@bootlin.com,
        gregory.clement@bootlin.com, miquel.raynal@bootlin.com,
        nadavh@marvell.com, stefanc@marvell.com, mw@semihalf.com,
        linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next] net: mvpp2: cls: Add Classification offload
 support
Message-ID: <20190420121714.387f160b@bootlin.com>
In-Reply-To: <20190419.150950.1875022930637674395.davem@davemloft.net>
References: <20190419133027.8012-1-maxime.chevallier@bootlin.com>
        <20190419.150950.1875022930637674395.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi David,

On Fri, 19 Apr 2019 15:09:50 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

>From: Maxime Chevallier <maxime.chevallier@bootlin.com>
>Date: Fri, 19 Apr 2019 15:30:27 +0200
>
>> +/* Internal represention of a Flow Steering rule */
>> +struct mvpp2_rfs_rule {
>> +	/* Rule location inside the flow*/
>> +	int loc;
>> +
>> +	/* Flow type, such as TCP_V4_FLOW, IP6_FLOW, etc. */
>> +	int flow_type;
>> +
>> +	/* The lookup type used by this flow. This allows the classification
>> +	 * engines to differentiate between entries that match the same
>> +	 * parameters
>> +	 */
>> +	int lu_type;
>> +
>> +	/* Index of the entry handling this rule in the flow table */
>> +	int flt_index;
>> +
>> +	/* Index of the C2 TCAM entry handling this rule */
>> +	int c2_index;  
>
>On 64-bit there will be a 32-bit hole here.  Why not put hek_fields
>and engine here?

You're right, I'll re-arrange that.

Thanks,

Maxime