Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 20 Apr 2019 13:22:20 +0200
From:   Oleg Nesterov <oleg@redhat.com>
To:     Zhenliang Wei <weizhenliang@huawei.com>
Cc:     ebiederm@xmission.com, colona@arista.com,
        akpm@linux-foundation.org, christian@brauner.io, arnd@arndb.de,
        tglx@linutronix.de, deepa.kernel@gmail.com,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH] signal: trace_signal_deliver when signal_group_exit
Message-ID: <20190420112219.GB17468@redhat.com>
References: <20190420104102.44336-1-weizhenliang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190420104102.44336-1-weizhenliang@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 04/20, Zhenliang Wei wrote:
>
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2441,6 +2441,8 @@ bool get_signal(struct ksignal *ksig)
>  	if (signal_group_exit(signal)) {
>  		ksig->info.si_signo = signr = SIGKILL;
>  		sigdelset(&current->pending.signal, SIGKILL);
> +		trace_signal_deliver(signr, &ksig->info,
> +				&sighand->action[signr - 1]);

Well, in this case ksig->info is not fully initialized for TP_STORE_SIGINFO()
which reads si_errno/si_code...

How about

		trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL)

?

We know that action[SIGKILL] must be SIG_DFL.

And SEND_SIG_NOINFO matches the fact that SIGKILL doesn't have any info,
collect_signal() sets SI_USER and clears si_errno in this case.

Oleg.