Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261939AbUDFCpV (ORCPT ); Mon, 5 Apr 2004 22:45:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263601AbUDFCpV (ORCPT ); Mon, 5 Apr 2004 22:45:21 -0400 Received: from smtp-out1.blueyonder.co.uk ([195.188.213.4]:62830 "EHLO smtp-out1.blueyonder.co.uk") by vger.kernel.org with ESMTP id S261939AbUDFCpO (ORCPT ); Mon, 5 Apr 2004 22:45:14 -0400 Message-ID: <40721A1A.6030705@blueyonder.co.uk> Date: Tue, 06 Apr 2004 03:46:50 +0100 From: Sid Boyce User-Agent: Mozilla Thunderbird 0.5 (X11/20040208) X-Accept-Language: en-us, en MIME-Version: 1.0 To: linux-kernel@vger.kernel.org Subject: Re: 2.6.5-mm1 References: <40715203.8070004@blueyonder.co.uk> <20040405153423.GK31152@smtp.west.cox.net> In-Reply-To: <20040405153423.GK31152@smtp.west.cox.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 06 Apr 2004 02:45:15.0147 (UTC) FILETIME=[307D5DB0:01C41B81] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1846 Lines: 56 This is the first kernel since 2.6.5-rc2 to have booted without locking up on the laptop. Regards Sid. Tom Rini wrote: >On Mon, Apr 05, 2004 at 01:33:07PM +0100, Sid Boyce wrote: > > > >>CC arch/x86_64/kernel/setup.o >>arch/x86_64/kernel/setup.c:258: warning: initialization from >>incompatible pointer type >>arch/x86_64/kernel/setup.c: In function `setup_arch': >>arch/x86_64/kernel/setup.c:411: error: `saved_command_line' undeclared >>(first use in this function) >>arch/x86_64/kernel/setup.c:411: error: (Each undeclared identifier is >>reported only once >>arch/x86_64/kernel/setup.c:411: error: for each function it appears in.) >>make[1]: *** [arch/x86_64/kernel/setup.o] Error 1 >>make: *** [arch/x86_64/kernel] Error 2 >>------------------------------------------------------------------- >>strlcpy(saved_command_line, early_command_line, COMMAND_LINE_SIZE); >> >> > >Yes, something like this is needed, on top of Rusty's early_param patch: >diff -puN include/linux/init.h~fix-rusty include/linux/init.h >--- linux-2.6.5-rc3/include/linux/init.h~fix-rusty 2004-04-02 08:30:50.600483739 -0700 >+++ linux-2.6.5-rc3-trini/include/linux/init.h 2004-04-02 08:30:50.604482833 -0700 >@@ -143,6 +143,7 @@ extern void setup_arch(void); > > /* Relies on saved_command_line being set */ > void __init parse_early_options(void); >+extern char saved_command_line[]; > #endif /* __ASSEMBLY__ */ > > /** > >Assuming that is, that arch/x86_64/kernel/setup.c has #include >, which I assume it does. > > > -- Sid Boyce .... Hamradio G3VBV and keen Flyer Linux Only Shop. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/