Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263746AbUDFKKZ (ORCPT ); Tue, 6 Apr 2004 06:10:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263751AbUDFKKZ (ORCPT ); Tue, 6 Apr 2004 06:10:25 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:13072 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S263746AbUDFKKT (ORCPT ); Tue, 6 Apr 2004 06:10:19 -0400 Date: Tue, 6 Apr 2004 11:10:13 +0100 From: Russell King To: Geert Uytterhoeven Cc: Linux Kernel Development Subject: Re: {put,get}_user() side effects Message-ID: <20040406111013.B15945@flint.arm.linux.org.uk> Mail-Followup-To: Geert Uytterhoeven , Linux Kernel Development References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from geert@linux-m68k.org on Tue, Apr 06, 2004 at 12:03:14PM +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 20 On Tue, Apr 06, 2004 at 12:03:14PM +0200, Geert Uytterhoeven wrote: > On most (all?) architectures {get,put}_user() has side effects: > > #define put_user(x,ptr) \ > __put_user_check((__typeof__(*(ptr)))(x),(ptr),sizeof(*(ptr))) I thought this came up before, and it was decided that put_user and get_user must not have such side effects - I certainly remember fixing this very thing on ARM. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/