Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263804AbUDFLsW (ORCPT ); Tue, 6 Apr 2004 07:48:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263853AbUDFLsW (ORCPT ); Tue, 6 Apr 2004 07:48:22 -0400 Received: from witte.sonytel.be ([80.88.33.193]:24974 "EHLO witte.sonytel.be") by vger.kernel.org with ESMTP id S263834AbUDFLqt (ORCPT ); Tue, 6 Apr 2004 07:46:49 -0400 Date: Tue, 6 Apr 2004 13:46:41 +0200 (MEST) From: Geert Uytterhoeven To: Andi Kleen cc: Linux Kernel Development Subject: Re: {put,get}_user() side effects In-Reply-To: Message-ID: References: <1HVGV-1Wl-21@gated-at.bofh.it> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1121 Lines: 28 On Tue, 6 Apr 2004, Andi Kleen wrote: > Geert Uytterhoeven writes: > > On most (all?) architectures {get,put}_user() has side effects: > > > > #define put_user(x,ptr) \ > > __put_user_check((__typeof__(*(ptr)))(x),(ptr),sizeof(*(ptr))) > > Neither typeof not sizeof are supposed to have side effects. If your > compiler generates them that's a compiler bug. >From a simple compile test, you seem to be right... Weird, since it does expand to 3 times 'pIndex++', but pIndex is incremented only once. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/