Date: Thu, 8 Apr 2004 00:27:48 +1000
From: Anton Blanchard <anton@samba.org>
To: Andi Kleen <ak@suse.de>
Cc: David Gibson <david@gibson.dropbear.id.au>, akpm@osdl.org,
       linux-kernel@vger.kernel.org, benh@kernel.crashing.org,
       paulus@samba.org, linuxppc64-dev@lists.linuxppc.org
Subject: Re: RFC: COW for hugepages
Message-ID: <20040407142748.GO26474@krispykreme>
References: <20040407074239.GG18264@zax> <20040407143447.4d8f08af.ak@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040407143447.4d8f08af.ak@suse.de>
User-Agent: Mutt/1.5.5.1+cvs20040105i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 725
Lines: 18

 
> Implementing this for ppc64 only is just wrong. Before you do this 
> I would suggest to factor out the common code in the various hugetlbpage
> implementations and then implement it in common code.

I could say a similar thing about your i386 specific largepage modifications
in the NUMA api :)

We should probably look at making lots of the arch specific hugetlb code
common but im not sure we want that to become a prerequisite for merging
NUMA API and hugepage COW.

Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/