Date: Wed, 7 Apr 2004 14:24:32 -0500
From: Andy Isaacson <adi@hexapodia.org>
To: Andrew Morton <akpm@osdl.org>
Cc: bug-coreutils@gnu.org, linux-kernel@vger.kernel.org
Subject: Re: dd PATCH: add conv=direct
Message-ID: <20040407192432.GD2814@hexapodia.org>
References: <20040406220358.GE4828@hexapodia.org> <20040406173326.0fbb9d7a.akpm@osdl.org> <20040407173116.GB2814@hexapodia.org> <20040407111841.78ae0021.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040407111841.78ae0021.akpm@osdl.org>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1079
Lines: 27

On Wed, Apr 07, 2004 at 11:18:41AM -0700, Andrew Morton wrote:
> Andy Isaacson <adi@hexapodia.org> wrote:
> > > While you're there, please add an fsync-before-closing option.
> > 
> > Easy enough.  How does this look?  Note that C_TWOBUFS ensures the
> > output buffer is getpagesize()-aligned.
> 
> Looks nice and simple.  You'll need an ext2 filesystem to test it under 2.4.

I tested against a block device.  Easier to just "swapoff /dev/hda2"
than to find space to make a new filesystem.

> Be aware that it's rather a challenge to actually get the O_DIRECT #define
> in scope under some glibc versions.  I think you need to define _GNU_SOURCE
> or something like that.

Yeah, I had to -D_GNU_SOURCE to build standalone, but coreutils'
makefile seems to do OK.

Would there be any reason to allow O_DIRECT on the read side?

-andy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/