Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261989AbUDHQAe (ORCPT ); Thu, 8 Apr 2004 12:00:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261937AbUDHQAe (ORCPT ); Thu, 8 Apr 2004 12:00:34 -0400 Received: from mion.elka.pw.edu.pl ([194.29.160.35]:25064 "EHLO mion.elka.pw.edu.pl") by vger.kernel.org with ESMTP id S261885AbUDHQAb (ORCPT ); Thu, 8 Apr 2004 12:00:31 -0400 From: Bartlomiej Zolnierkiewicz To: Geert Uytterhoeven Subject: Re: [PATCH] obsolete asm/hdreg.h [3/5] Date: Thu, 8 Apr 2004 18:09:09 +0200 User-Agent: KMail/1.5.3 Cc: Linux Kernel Development , linux-ide@vger.kernel.org References: <200404080023.04460.bzolnier@elka.pw.edu.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200404081809.09937.bzolnier@elka.pw.edu.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1665 Lines: 46 On Thursday 08 of April 2004 10:49, Geert Uytterhoeven wrote: > On Thu, 8 Apr 2004, Bartlomiej Zolnierkiewicz wrote: > > [IDE] asm/ide.h: ide_ioreg_t cleanup > > > > ide_ioreg_t is deprecated and hasn't been used by IDE driver for some > > time. Use unsigned long directly on alpha, arm26, arm, mips, parisc, > > ppc64 and sh. > > > > asm-ia64/ide.h (ide_ioreg_t is unsigned short) and asm-m68knommu/ide.h > > (broken - ide_ioreg_t is not defined) are the only users of ide_ioreg_t > > left. > > Why do you consider asm-m68knommu/ide.h broken? > > It just includes , which is definitely not broken since > it's happily (albeit very slowly) running apt-get upgrade right now ;-) Well... In kernel 2.5.70 ide_ioreg_t typedef was removed from and it is used all over . I see that this is fixed in linux-m68k-cvs but... hasn't been updated since kernel 2.5.46 and still depends on inlines which were removed from IDE code: - ide_request_irq() (special case for COLDFIRE) - ide_{request, release}_region(), which are empty because M68K use memory IO - ide_fix_driveid() (special case for COLDFIRE), conflicts with generic version in drivers/ide/ide-iops.c - maybe more This issues are not fixed in linux-m68k-cvs tree. [ Is there a separate m68knommu tree? ] I hope you now don't regret asking this question... ;-) Cheers, Bartlomiej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/