Date: Thu, 8 Apr 2004 12:29:30 -0700
From: Chris Wright <chrisw@osdl.org>
To: Chris Wright <chrisw@osdl.org>, linux-kernel@vger.kernel.org,
       Nick.Holloway@pyrites.org.uk
Subject: Re: [PATCH 2.6] Add missing MODULE_PARAM to dummy.c (and MAINTAINERShip)
Message-ID: <20040408122930.S21045@build.pdx.osdl.net>
References: <20040408174823.GA13335@localhost> <20040408105440.G22989@build.pdx.osdl.net> <20040408185903.GA21236@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20040408185903.GA21236@localhost>; from linux-kernel@24x7linux.com on Thu, Apr 08, 2004 at 08:59:03PM +0200
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1480
Lines: 36

* Jose Luis Domingo Lopez (linux-kernel@24x7linux.com) wrote:
> On Thursday, 08 April 2004, at 10:54:40 -0700,
> Chris Wright wrote:
> 
> > this is going backwards.  module_param is the newer (preferred) interface.
> > 
> I (incorrectly) based my assumptions on the fact that "modinfo dummy"
> didn't return any information about the module parameter. I also had a
> look at some other modules, like "bonding", "rtl8139", and I assumed
> that the MODULE_* macros were the 2.6.x way of doing things.

It's a mix.  module_param(), MODULE_PARM_DESC(), MODULE_LICENSE(),
MODULE_AUTHOR(), MODULE_DESCRIPTION().

So the whole patch isn't bad, just the bit like:
-module_param()
+MODULE_PARM()

> I was obviously wrong, sorry for the waste of time (anyways, it seems
> there are several kernel modules waiting to be updated, maybe I should
> give them a look and learn something and try to "fix" them).

Sure, although some of these changes may not be accepted simply because
they create noise, patch conflicts etc at a time where stability is more
important.  So new code should use the new ones, old code may not all be
converted for some time.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/