Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262462AbUDHT7g (ORCPT ); Thu, 8 Apr 2004 15:59:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262499AbUDHT7L (ORCPT ); Thu, 8 Apr 2004 15:59:11 -0400 Received: from mirapoint1.TIS.CWRU.Edu ([129.22.104.46]:39433 "EHLO mirapoint1.tis.cwru.edu") by vger.kernel.org with ESMTP id S262462AbUDHTvS (ORCPT ); Thu, 8 Apr 2004 15:51:18 -0400 To: Paul Eggert Cc: Jim Meyering , Andrew Morton , Bruce Allen , bug-coreutils@gnu.org, linux-kernel@vger.kernel.org, Andy Isaacson Subject: Re: dd PATCH: add conv=direct In-Reply-To: <87vfkaw9i9.fsf@penguin.cs.ucla.edu> (Paul Eggert's message of "Thu, 08 Apr 2004 12:32:46 -0700") References: <87r7uzlzz7.fsf@penguin.cs.ucla.edu> <85k70qsp71.fsf@pi.meyering.net> <87vfkaw9i9.fsf@penguin.cs.ucla.edu> From: prj@po.cwru.edu (Paul Jarc) Organization: What did you have in mind? A short, blunt, human pyramid? Mail-Copies-To: nobody Mail-Followup-To: Paul Eggert , Jim Meyering , Andrew Morton , Bruce Allen , bug-coreutils@gnu.org, linux-kernel@vger.kernel.org, Andy Isaacson Date: Thu, 08 Apr 2004 15:51:11 -0400 Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 696 Lines: 14 Paul Eggert wrote: > Jim Meyering writes: >> 2004-04-08 Jim Meyering >> >> * src/dd.c (set_fd_flags): Don't OR in -1 when fcntl fails. > > Doesn't that fix generate worse code in the usual case, since it > causes two conditional branches instead of one? I think it's unnecessary anyway - if old_flags is -1, then the conditional jumps to error() before looking at new_flags at all. paul - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/