Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262068AbUDHVjy (ORCPT ); Thu, 8 Apr 2004 17:39:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262079AbUDHVjy (ORCPT ); Thu, 8 Apr 2004 17:39:54 -0400 Received: from meyering.net1.nerim.net ([62.212.115.149]:1577 "EHLO elf.meyering.net") by vger.kernel.org with ESMTP id S262068AbUDHVjx (ORCPT ); Thu, 8 Apr 2004 17:39:53 -0400 To: Paul Eggert Cc: bug-coreutils@gnu.org, Andrew Morton , Bruce Allen , linux-kernel@vger.kernel.org, Andy Isaacson Subject: Re: dd patch to remove noctty In-Reply-To: <87ekqyw79y.fsf_-_@penguin.cs.ucla.edu> (Paul Eggert's message of "Thu, 08 Apr 2004 13:20:57 -0700") References: <87r7uzlzz7.fsf@penguin.cs.ucla.edu> <87vfka30cm.fsf@ceramic.fifi.org> <87ekqyw79y.fsf_-_@penguin.cs.ucla.edu> From: Jim Meyering Date: Thu, 08 Apr 2004 23:40:23 +0200 Message-ID: <85d66iqhbs.fsf@pi.meyering.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 19 Paul Eggert wrote: > Philippe Troin writes: > >> noctty definitely seems overkill... I can't see why dd would ever want >> to open a file without O_NOCTTY. > > Good point; it's just a confusion for the user. Here's a patch to > cause dd to always use O_NOCTTY. If someone ever needs it the other > way (not likely) I suppose we can add a "ctty" flag. > > 2004-04-08 Paul Eggert > > * NEWS: Remove noctty flag from dd. Suggested by Philippe Troin. > * doc/coreutils.texi (dd invocation): Likewise. > * src/shred.c (O_NOCTTY): Remove redundant decl. > * src/dd.c (flags, usage): Remove noctty flag. > (main): Always use O_NOCTTY when opening files. Applied. Thanks! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/