Date: Fri, 9 Apr 2004 18:21:23 -0300
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Message-ID: <20040409212123.GB18694@logos.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.5.1i
Subject: [PATCH] drivers/char/KConfig: Remove "BROKEN_ON_SMP" tag on CYCLADES entry
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1154
Lines: 35


Hi Andrew, 

The cyclades.c driver was marked BROKEN_ON_SMP during early 2.6. It was fixed later
on but the tag was left in Kconfig.

The driver is not very smart wrt SMP locking, it can be improved. There is only 
one spinlock percard which guarantees command block ordering and protects different
shared data, which can be held for long periods.

_But_ the locking works reliably, so remove the BROKEN_ON_SMP tag.

Please apply.


--- linux-2.6.5-mc2.orig/drivers/char/Kconfig	2004-04-09 17:49:22.703814096 -0300
+++ linux-2.6.5-mc2/drivers/char/Kconfig	2004-04-08 18:04:21.000000000 -0300
@@ -110,7 +110,7 @@
 
 config CYCLADES
 	tristate "Cyclades async mux support"
-	depends on SERIAL_NONSTANDARD && BROKEN_ON_SMP
+	depends on SERIAL_NONSTANDARD
 	---help---
 	  This is a driver for a card that gives you many serial ports. You
 	  would need something like this to connect more than two modems to


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/