Date: Mon, 12 Apr 2004 20:42:23 -0700
From: Andrew Morton <akpm@osdl.org>
To: Albert Cahalan <albert@users.sourceforge.net>
Cc: linux-kernel@vger.kernel.org, mpm@selenic.com
Subject: Re: [PATCH] eliminate nswap and cnswap
Message-Id: <20040412204223.2a07d123.akpm@osdl.org>
In-Reply-To: <1081827102.1593.227.camel@cube>
References: <1081827102.1593.227.camel@cube>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1110
Lines: 26

Albert Cahalan <albert@users.sourceforge.net> wrote:
>
> > The nswap and cnswap variables counters have never
> > been incremented as Linux doesn't do task swapping.
> 
> I'm pretty sure they were used for paging activity.
> We don't eliminate support for "swap space", do we?
> 
> Somebody must have broken nswap and cnswap while
> hacking on some vm code. I hate to see the variables
> get completely ripped out of the kernel instead of
> getting fixed.

There's nothing in 2.4 which increments these, nor was there in 2.6.  Which
tends to imply that they weren't very important.

We could sort-of do this - move them into mm_struct (doing it in
task_struct was always wrong) and increment them in the VM.  But we'd need
some reason why these statistics are interesting, and we'd need an
explanation of what nswap and cnswap are actually supposed to represent.  

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/