Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263820AbUDNHCa (ORCPT ); Wed, 14 Apr 2004 03:02:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263927AbUDNHCa (ORCPT ); Wed, 14 Apr 2004 03:02:30 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:22502 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S263820AbUDNHC3 (ORCPT ); Wed, 14 Apr 2004 03:02:29 -0400 Date: Wed, 14 Apr 2004 08:02:27 +0100 From: viro@parcelfarce.linux.theplanet.co.uk To: Maneesh Soni Cc: LKML , Greg KH Subject: Re: [RFC] fix sysfs symlinks Message-ID: <20040414070227.GA31500@parcelfarce.linux.theplanet.co.uk> References: <20040413124037.GA21637@in.ibm.com> <20040413133615.GZ31500@parcelfarce.linux.theplanet.co.uk> <20040414064015.GA4505@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040414064015.GA4505@in.ibm.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 22 On Wed, Apr 14, 2004 at 12:10:16PM +0530, Maneesh Soni wrote: > I am not sure, if pinning the kobject for the life time of symlink (dentry) > may result in same problems like rmmod hang which we saw in case of pinning > kobject for the life time of its directory (dentry). Erm... If rmmod _ever_ waits for refcount on kobject to reach zero, it's already broken. Do you have any examples of such behaviour? > + pr_debug("%s: path = '%s'\n", __FUNCTION__, path); > + > + return error; ITYM return 0; BTW, replace leading spaces with tab, please - you've got a tabdamage very visible in patch. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/