Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261690AbUDOEhA (ORCPT ); Thu, 15 Apr 2004 00:37:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263745AbUDOEhA (ORCPT ); Thu, 15 Apr 2004 00:37:00 -0400 Received: from pfepa.post.tele.dk ([195.41.46.235]:17277 "EHLO pfepa.post.tele.dk") by vger.kernel.org with ESMTP id S261690AbUDOEg7 (ORCPT ); Thu, 15 Apr 2004 00:36:59 -0400 Date: Thu, 15 Apr 2004 06:44:52 +0200 From: Sam Ravnborg To: Rusty Russell Cc: Arkadiusz Miskiewicz , Andrew Morton , lkml - Kernel Mailing List Subject: Re: modules in 2.6 kernel - question for FAQ? Message-ID: <20040415044452.GA2215@mars.ravnborg.org> Mail-Followup-To: Rusty Russell , Arkadiusz Miskiewicz , Andrew Morton , lkml - Kernel Mailing List References: <200404142142.41137.arekm@pld-linux.org> <1081993968.17782.112.camel@bach> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1081993968.17782.112.camel@bach> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 782 Lines: 20 On Thu, Apr 15, 2004 at 11:52:48AM +1000, Rusty Russell wrote: > On Thu, 2004-04-15 at 05:42, Arkadiusz Miskiewicz wrote: > > insmod: error inserting './Intel537.ko': -1 Invalid module format > > They didn't use -fno-common. The patch which adds in the warning got > lost a while back. > > Here's a new one... Is it be possible to detect this during the modpost stage, or do they manage to avoid that in some way? I would rather see the error a bit earlier. Eventually depmod. Still your patch make relevance as a double check. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/