Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263988AbUDONvO (ORCPT ); Thu, 15 Apr 2004 09:51:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263908AbUDONvO (ORCPT ); Thu, 15 Apr 2004 09:51:14 -0400 Received: from zero.aec.at ([193.170.194.10]:45067 "EHLO zero.aec.at") by vger.kernel.org with ESMTP id S263988AbUDONvL (ORCPT ); Thu, 15 Apr 2004 09:51:11 -0400 To: "Tomar, Nagendra" cc: linux-kernel@vger.kernel.org Subject: Re: why change_page_attr on x86 uses __flush_tlb_all References: <1Lek1-5lB-3@gated-at.bofh.it> From: Andi Kleen Date: Thu, 15 Apr 2004 15:51:07 +0200 In-Reply-To: <1Lek1-5lB-3@gated-at.bofh.it> (Nagendra Singh Tomar's message of "Thu, 15 Apr 2004 14:40:09 +0200") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 17 Nagendra Singh Tomar writes: > I would expect __flush_tlb_one (for each page) as a better choice. > It'll be nice if someone can hoghlight on why __flush_tlb_all is used. > The kernel version I am referring from is 2.4.18-14 This works around a bug in some early Athlons with flushing global large pages. Also it makes the code slightly simpler and change_page_attr is not really performance critical. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/