Date: Thu, 15 Apr 2004 13:38:45 -0700
From: Chris Wright <chrisw@osdl.org>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Chris Wright <chrisw@osdl.org>, Andrew Morton <akpm@osdl.org>,
       Jakub Jelinek <jakub@redhat.com>, Ulrich Drepper <drepper@redhat.com>,
       Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mq_open() honor leading slash
Message-ID: <20040415133845.T22989@build.pdx.osdl.net>
References: <20040415113951.G21045@build.pdx.osdl.net> <407EEF6C.6030408@colorfullife.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <407EEF6C.6030408@colorfullife.com>; from manfred@colorfullife.com on Thu, Apr 15, 2004 at 10:24:12PM +0200
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 940
Lines: 23

* Manfred Spraul (manfred@colorfullife.com) wrote:
> Chris Wright wrote:
> >Patch below simply eats all leading slashes before passing name to
> >lookup_one_len() in mq_open() and mq_unlink().
> >
> Why should we do that in kernel space?
> The kernel interface is "no slash at all". User space can add a SuS 
> compatible layer on top of the kernel interface (i.e. fail with -EINVAL 
> if the first character is not a /, then skip the slash and pass "name+1" 
> to sys_mq_open()).

Jakub said similar, and I missed the fact that glibc was sanitizing
before calling kernel.  I agree, it's fine as is.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/