Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263916AbUDPXNX (ORCPT ); Fri, 16 Apr 2004 19:13:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263919AbUDPXNX (ORCPT ); Fri, 16 Apr 2004 19:13:23 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:24711 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S263916AbUDPXNT (ORCPT ); Fri, 16 Apr 2004 19:13:19 -0400 Message-ID: <40806880.1030007@pobox.com> Date: Fri, 16 Apr 2004 19:13:04 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703 X-Accept-Language: en-us, en MIME-Version: 1.0 To: viro@parcelfarce.linux.theplanet.co.uk CC: Dave Jones , Linus Torvalds , Linux Kernel , bfennema@falcon.csc.calpoly.edu Subject: Re: Fix UDF-FS potentially dereferencing null References: <20040416214104.GT20937@redhat.com> <20040416220014.GI24997@parcelfarce.linux.theplanet.co.uk> In-Reply-To: <20040416220014.GI24997@parcelfarce.linux.theplanet.co.uk> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 643 Lines: 22 viro@parcelfarce.linux.theplanet.co.uk wrote: > On Fri, Apr 16, 2004 at 10:41:04PM +0100, Dave Jones wrote: > >>Move size instantiation after null check for 'dir', nearer >>to where its first used. > > > Check in question is a BS - it never gets NULL passed as dir. Yes, it looks like a lot of these NULL checks caught can be fixed simply by removing bogus and/or redundant checks. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/