Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263576AbUDPXnx (ORCPT ); Fri, 16 Apr 2004 19:43:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263974AbUDPXmK (ORCPT ); Fri, 16 Apr 2004 19:42:10 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:63112 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S263576AbUDPXkp (ORCPT ); Fri, 16 Apr 2004 19:40:45 -0400 Message-ID: <40806EF0.1020607@pobox.com> Date: Fri, 16 Apr 2004 19:40:32 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Chris Wright CC: Dave Jones , viro@parcelfarce.linux.theplanet.co.uk, Linux Kernel Subject: Re: baycom_par dereference before check. References: <20040416212004.GO20937@redhat.com> <20040416212541.GH24997@parcelfarce.linux.theplanet.co.uk> <20040416212738.GQ20937@redhat.com> <408054C9.5070202@pobox.com> <20040416215319.GW20937@redhat.com> <20040416160759.D22989@build.pdx.osdl.net> In-Reply-To: <20040416160759.D22989@build.pdx.osdl.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1193 Lines: 37 Chris Wright wrote: > * Dave Jones (davej@redhat.com) wrote: > >>On Fri, Apr 16, 2004 at 05:48:57PM -0400, Jeff Garzik wrote: >> > >Good point. Still doesn't strike me as particularly nice though. >> > I would rather just remove the checks completely. The success of any of >> > those checks is a BUG() condition that should never occur. >> >>That works for me too. How about this? >> >> Dave >> >>--- linux-2.6.5/drivers/net/hamradio/baycom_par.c~ 2004-04-16 22:52:35.000000000 +0100 >>+++ linux-2.6.5/drivers/net/hamradio/baycom_par.c 2004-04-16 22:52:53.000000000 +0100 >>@@ -274,8 +274,8 @@ >> struct net_device *dev = (struct net_device *)dev_id; >> struct baycom_state *bc = netdev_priv(dev); >> >>- if (!dev || !bc || bc->hdrv.magic != HDLCDRV_MAGIC) >>- return; >>+ BUG_ON(!bc); > > > If it's adding a constant offset to dev, the bc would be non-NULL in a bug > case, no? I'm just going to remove the checks completely. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/