Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264367AbUDSKSL (ORCPT ); Mon, 19 Apr 2004 06:18:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264369AbUDSKSL (ORCPT ); Mon, 19 Apr 2004 06:18:11 -0400 Received: from mail.shareable.org ([81.29.64.88]:5540 "EHLO mail.shareable.org") by vger.kernel.org with ESMTP id S264367AbUDSKRi (ORCPT ); Mon, 19 Apr 2004 06:17:38 -0400 Date: Mon, 19 Apr 2004 11:17:31 +0100 From: Jamie Lokier To: Linus Torvalds Cc: chris@scary.beasts.org, akpm@osdl.org, linux-kernel@vger.kernel.org Subject: [PATCH] Use get_user for 64-bit read in sendfile64 Message-ID: <20040419101731.GD13007@mail.shareable.org> References: <20040419004657.GD11064@mail.shareable.org> <20040419094408.GA13007@mail.shareable.org> <20040419101446.GC13007@mail.shareable.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040419101446.GC13007@mail.shareable.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 22 Patch: sendfile64_get_user-2.6.5 Requires: uaccess64-2.6.5-jl2 Use get_user instead of copy_from_user to read a loff_t. Compiled output is identical on i386. --- orig-2.6.5/fs/read_write.c 2004-04-14 08:29:43.000000000 +0100 +++ uaccess64-2.6.5/fs/read_write.c 2004-04-19 10:35:35.000000000 +0100 @@ -644,7 +644,7 @@ ssize_t ret; if (offset) { - if (unlikely(copy_from_user(&pos, offset, sizeof(loff_t)))) + if (unlikely(get_user(pos, offset))) return -EFAULT; ret = do_sendfile(out_fd, in_fd, &pos, count, 0); if (unlikely(put_user(pos, offset))) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/