Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261422AbUDSQa5 (ORCPT ); Mon, 19 Apr 2004 12:30:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261430AbUDSQa5 (ORCPT ); Mon, 19 Apr 2004 12:30:57 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:12305 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S261422AbUDSQau (ORCPT ); Mon, 19 Apr 2004 12:30:50 -0400 Date: Mon, 19 Apr 2004 17:30:47 +0100 From: Russell King To: Geert Uytterhoeven Cc: Linux Kernel List , Jes Sorensen , Linux/m68k Subject: Re: [PATCH] Clean up asm/pgalloc.h include (m68k) Message-ID: <20040419173046.E29446@flint.arm.linux.org.uk> Mail-Followup-To: Geert Uytterhoeven , Linux Kernel List , Jes Sorensen , Linux/m68k References: <20040418231720.C12222@flint.arm.linux.org.uk> <20040418232314.A2045@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from geert@linux-m68k.org on Mon, Apr 19, 2004 at 06:18:41PM +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1568 Lines: 46 On Mon, Apr 19, 2004 at 06:18:41PM +0200, Geert Uytterhoeven wrote: > The patch below fixes all compile-issues on m68k, except when compiling for > Sun-3. > > include/asm-generic/tlb.h now includes , which includes > . But the last file needs tlb_remove_page(), which is > defined in include/asm-generic/tlb.h Nice. > Do you really need in include/asm-generic/tlb.h? Yes it does - tlb.h uses check_pgt_cache(). Also, architecture code makes use of __pmd_free_tlb and __pte_free_tlb, both of which make use of code from asm/pgalloc.h. Not including asm/pgalloc.h into asm/tlb.h or asm-generic/tlb.h means that all the generic files have to know that asm/tlb.h needs asm/pgalloc.h, and they also then need to know that asm/pgalloc.h needs asm/pgtable.h, and asm/pgtable.h needs ... Is there a reason why: static inline void __pte_free_tlb(struct mmu_gather *tlb, struct page *page) { tlb_remove_page(tlb, page); } can't be like x86 and others in their pgalloc.h: #define __pte_free_tlb(tlb,pte) tlb_remove_page((tlb),(pte)) (for consistency sake if nothing else) ? Thanks. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/