Subject: Re: [PATCH 2.6.6rc1-mm1] NFS sysctlized - readahead tunable
From: Fabian Frederick <Fabian.Frederick@skynet.be>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: lkml <linux-kernel@vger.kernel.org>
In-Reply-To: <1082408907.3360.14.camel@lade.trondhjem.org>
References: <1082407753.18853.12.camel@bluerhyme.real3>
	 <1082408907.3360.14.camel@lade.trondhjem.org>
Content-Type: text/plain
Message-Id: <1082410183.19241.12.camel@bluerhyme.real3>
Mime-Version: 1.0
Date: Mon, 19 Apr 2004 23:29:43 +0200
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1854
Lines: 45

On Mon, 2004-04-19 at 23:08, Trond Myklebust wrote:
> On Mon, 2004-04-19 at 16:49, Fabian Frederick wrote:
> > Trond,
> > 
> > 	Here is a patch to have nfs to sysctl although Maxreadahead is tunable
> > under nfs init only.Do you have an idea and do you think it's acceptable
> > to make it applicable directly i.e. would it be readahead reduction
> > tolerant ?
> > 
> > btw, is this inode.c an issue for V4 ?
> > 
> 
> The lockd module has already registered the name /proc/sys/fs/nfs, so
> your scheme will end up corrupting the sysctl list. Sorting out the
> /proc namespace issue is the main reason why this hasn't been done
> before.
> Personally, I'd prefer renaming the lockd module into
> /proc/sys/fs/lockd, but it will have to be up to Andrew to decide
> whether he wants to allow that during a stable kernel cycle.
AFAICS one of the first sysctl concepts is to be redundancy tolerant.
If you take fs for instance, it's being declared here and there.
It means "if it doens't exist yet, we create it with mode (555) else
 go cycle to the sub-branch (fs-nfs....) btw, we have a register(fs) so
no problem for me.Lockd has to do with nfs so it should be preserved at
the same place IMHO.

> 
> Also note that putting initializers into a ".h" file is horrible style.
> ".h" files should be for forward declarations only.
I used both ntfs, coda fs scheme having in mind independant sysctl
registering in forthcoming releases.

But hey ! "I'm an absolute beginner" :) Maybe you and Andrew can tell me
what to do with this ugly patch ;) e.g. no sysctl.h -> include stuff in
inode.c ...

Regards,
FabianF


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/