Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263062AbUDTQB3 (ORCPT ); Tue, 20 Apr 2004 12:01:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263093AbUDTQB3 (ORCPT ); Tue, 20 Apr 2004 12:01:29 -0400 Received: from bay-bridge.veritas.com ([143.127.3.10]:18859 "EHLO MTVMIME01.enterprise.veritas.com") by vger.kernel.org with ESMTP id S263062AbUDTQB1 (ORCPT ); Tue, 20 Apr 2004 12:01:27 -0400 Date: Tue, 20 Apr 2004 17:01:17 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@localhost.localdomain To: Paul Mundt cc: Russell King , Linux Kernel List Subject: Re: [PATCH] Clean up asm/pgalloc.h include (sh) In-Reply-To: <20040420144659.GE12390@linux-sh.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 916 Lines: 21 On Tue, 20 Apr 2004, Paul Mundt wrote: > Failed to compile. sh has ptep_get_and_clear in asm/pgalloc.h. > This moves it out of the way, and your patch builds fine. Paul, the patch you show reflects how ptep_get_and_clear looked in 2.6.5, but not how it now looks in 2.6.6-rc1-bk - should be using page_mapping(page) and mapping_writably_mapped(mapping). I dare say you're referring to a master tree into which the recent mainline changes need to be ported (I CC'ed gniibe@m17n.org when sending those changes to akpm): I'm not saying your version is wrong, just trying to make sure that two sets of changes in the same area don't end up with one set getting lost. Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/