Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263171AbUDTQXw (ORCPT ); Tue, 20 Apr 2004 12:23:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263172AbUDTQXw (ORCPT ); Tue, 20 Apr 2004 12:23:52 -0400 Received: from mail.kroah.org ([65.200.24.183]:23784 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S263171AbUDTQXt (ORCPT ); Tue, 20 Apr 2004 12:23:49 -0400 Date: Tue, 20 Apr 2004 09:16:02 -0700 From: Greg KH To: viro@parcelfarce.linux.theplanet.co.uk Cc: Jeff Garzik , Maneesh Soni , LKML Subject: Re: [RFC] fix sysfs symlinks Message-ID: <20040420161602.GB9603@kroah.com> References: <20040413124037.GA21637@in.ibm.com> <20040413133615.GZ31500@parcelfarce.linux.theplanet.co.uk> <20040415220232.GC23039@kroah.com> <20040416152448.GF24997@parcelfarce.linux.theplanet.co.uk> <20040416223732.GC21701@kroah.com> <20040416234601.GL24997@parcelfarce.linux.theplanet.co.uk> <40807466.1020701@pobox.com> <20040417090712.B11481@flint.arm.linux.org.uk> <20040417082206.GM24997@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040417082206.GM24997@parcelfarce.linux.theplanet.co.uk> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1265 Lines: 27 On Sat, Apr 17, 2004 at 09:22:06AM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote: > On Sat, Apr 17, 2004 at 09:07:12AM +0100, Russell King wrote: > > What about other bus types? Do I really need to teach userspace about > > the relationships between all the various bus types we have on ARM and > > how to work out what these relationships are by guessing? > > > > Please. The symlinks are necessary and they are the sole source of > > the relationship information. > > In which case you want them to be associated with target, not the current > pathname of target. And no, I don't buy the "so far all renames happen *here* > and all symlinks are pointing *there*, so we don't care" - that won't last. > > When do we have a legitimate reason for dangling symlinks in sysfs, anyway? Ok, in thinking about it some more, we don't. And I don't have a problem with grabbing the reference to the target anymore either (after looking over the code). So no more objections from me about this :) thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/