Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263325AbUDUQKe (ORCPT ); Wed, 21 Apr 2004 12:10:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263366AbUDUQKd (ORCPT ); Wed, 21 Apr 2004 12:10:33 -0400 Received: from phoenix.infradead.org ([213.86.99.234]:36104 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S263325AbUDUQKG (ORCPT ); Wed, 21 Apr 2004 12:10:06 -0400 Date: Wed, 21 Apr 2004 17:09:58 +0100 From: Christoph Hellwig To: raven@themaw.net Cc: Andrew Morton , Al Viro , Kernel Mailing List Subject: Re: 2.6.6-rc1-mm1 Message-ID: <20040421170958.A7784@infradead.org> Mail-Followup-To: Christoph Hellwig , raven@themaw.net, Andrew Morton , Al Viro , Kernel Mailing List References: <20040418230131.285aa8ae.akpm@osdl.org> <20040419202538.A15701@infradead.org> <20040419182657.7870aee9.akpm@osdl.org> <20040421100835.A3577@infradead.org> <20040421141829.A5551@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from raven@themaw.net on Wed, Apr 21, 2004 at 11:52:18PM +0800 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 546 Lines: 13 On Wed, Apr 21, 2004 at 11:52:18PM +0800, raven@themaw.net wrote: > > Any chance to use list_for_each_entry here? > > It looks to me like this macro can't be used for a tree traversal. > Please enlighten me if I'm wrong. Umm, indeed. The control flow in that function is a little too convoluted :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/