Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263888AbUDVJky (ORCPT ); Thu, 22 Apr 2004 05:40:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263889AbUDVJky (ORCPT ); Thu, 22 Apr 2004 05:40:54 -0400 Received: from smtpout.mac.com ([17.250.248.46]:64218 "EHLO smtpout.mac.com") by vger.kernel.org with ESMTP id S263888AbUDVJkx (ORCPT ); Thu, 22 Apr 2004 05:40:53 -0400 Message-ID: <2899705.1082626850875.JavaMail.pwaechtler@mac.com> Date: Thu, 22 Apr 2004 11:40:50 +0200 From: Peter Waechtler To: Andrew Morton Subject: Re: [PATCH] coredump - as root not only if euid switched Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1091 Lines: 31 On Thursday, April 22, 2004, at 10:55AM, Andrew Morton wrote: >Peter Waechtler wrote: >> >> But I agree that sys_unlink should be the fast call and dumping core >> is the exception :) >> >> would fastcall do_unlink() help? I guess the arg is then passed in a >> register > >I've never been able to measure any size or space benefit for fastcall, and >we do it via compiler options kernel-wide nowadays. > >The above will work fine. You can probably just open-code it at the place >where you're unlinking the file. > >(why are you trying to unlink the old file anyway?) > For security measure :O I tried on solaris: touch the core file as user, open it and wait, dump core as root -> nope, couldn't read the damn core - it was unlinked and created! So do I want. I will sent the new patch from home. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/