Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264119AbUDVPQP (ORCPT ); Thu, 22 Apr 2004 11:16:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264116AbUDVPQO (ORCPT ); Thu, 22 Apr 2004 11:16:14 -0400 Received: from mx1.redhat.com ([66.187.233.31]:51412 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S264119AbUDVPQN (ORCPT ); Thu, 22 Apr 2004 11:16:13 -0400 Date: Thu, 22 Apr 2004 11:15:47 -0400 (EDT) From: James Morris X-X-Sender: jmorris@thoron.boston.redhat.com To: Andi Kleen cc: linux-kernel@vger.kernel.org, Subject: Re: Large inlines in include/linux/skbuff.h In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 25 On Thu, 22 Apr 2004, Andi Kleen wrote: > > How will these changes impact performance? I asked this last time you > > posted about inlines and didn't see any response. > > I don't think it will be an issue. The optimization guidelines > of AMD and Intel recommend to move functions that generate > more than 30-40 instructions out of line. 100 instructions > is certainly enough to amortize the call overhead, and you > safe some icache too so it may be even faster. Of course, but it would be good to see some measurements. - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/