content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 8BIT
Subject: RE: [patch 1/3] efivars driver update and move
Date: Thu, 22 Apr 2004 10:14:05 -0700
Message-ID: <D36CE1FCEFD3524B81CA12C6FE5BCAB002FFEAB3@fmsmsx406.fm.intel.com>
Thread-Topic: [patch 1/3] efivars driver update and move
Thread-Index: AcQoiXClS/Fo3Q3fRqmFKH7vAFFu9QAAY/cA
From: "Tolentino, Matthew E" <matthew.e.tolentino@intel.com>
To: "Bjorn Helgaas" <bjorn.helgaas@hp.com>,
       "Matt Tolentino" <metolent@snoqualmie.dp.intel.com>
Cc: <akpm@osdl.org>, <linux-ia64@vger.kernel.org>,
       <linux-kernel@vger.kernel.org>, <Matt_Domsch@dell.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1147
Lines: 45

> I like these changes.

Thanks!  

> I did notice that the new drivers/.../efivars.c is not identical to
> the old arch/ia64/kernel/efivars.c (the hints to emacs were removed).
> I like the emacs hint removal, but didn't review patch for any other
> differences.

Right, it's been fully converted to sysfs.  Just for reference, the 
resultant sysfs tree looks something like:

/sys |
     ...
     |-firmware 
	       |-efi
		   |-systab
		   |-vars 
			 |- BootNext-xxxx-xxx-x-x-x-x *
				|-attributes
				|-data
				|-guid
				|-raw_var
				|-size
			 |- BootCurrent-xxxxxx-x-x-x-x *
			 |- ConOut-xxxx-x-x-x-x-x-x-*
			 ...
			 |- del_var
			 |- new_var 

where xxxx-x-x-x-x-x is the GUID.  

> Any plans to consolidate other bits from efi.c?  There are a number
> of things there that look like they could be shared:

Yes, I plan to consolidate as much of the common code as possible soon.


matt

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/